r24966 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24965‎ | r24966 | r24967 >
Date:21:37, 20 August 2007
Author:raymond
Status:old
Tags:
Comment:
Fix a regression from r24808:
PHP-Notice: 'Undefined variable:'
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
@@ -613,7 +613,7 @@
614614 );
615615 if ( $framed ) $frameParams['framed'] = true;
616616 if ( $manualthumb ) $frameParams['manualthumb'] = $manualthumb;
617 - return $this->makeThumbLink2( $title, $file, $frameParams, $handlerParams );
 617+ return $this->makeThumbLink2( $title, $file, $frameParams, $params );
618618 }
619619
620620 function makeThumbLink2( Title $title, $file, $frameParams = array(), $handlerParams = array() ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r24969Static code analysis housekeeping time... things that could be double-checked...nickj03:57, 21 August 2007
r25016Merged revisions 24866-25015 via svnmerge from...david23:06, 21 August 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r24808Basic integrated audio/video support, with Ogg implementation....tstarling10:50, 15 August 2007

Status & tagging log