r24949 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24948‎ | r24949 | r24950 >
Date:13:58, 20 August 2007
Author:robchurch
Status:old
Tags:
Comment:
Don't pass false as attributes in Xml method arguments; causes bad things to happen
Modified paths:
  • /trunk/extensions/OggHandler/OggHandler_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OggHandler/OggHandler_body.php
@@ -362,7 +362,7 @@
363363 $this->isVideo = $isVideo;
364364 }
365365
366 - function toHtml( $attribs = array() , $linkAttribs = false ) {
 366+ function toHtml( $attribs = array() , $linkAttribs = array() ) {
367367 wfLoadExtensionMessages( 'OggHandler' );
368368
369369 OggTransformOutput::$serial++;

Status & tagging log