r24935 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24934‎ | r24935 | r24936 >
Date:08:13, 20 August 2007
Author:nickj
Status:old
Tags:
Comment:
Variable $titleString seemed to be used before it was defined - removing.
Modified paths:
  • /trunk/phase3/includes/api/ApiPageSet.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiPageSet.php
@@ -580,7 +580,7 @@
581581
582582 $titleObj = is_string($title) ? Title :: newFromText($title) : $title;
583583 if (!$titleObj)
584 - $this->dieUsage("bad title $titleString", 'invalidtitle');
 584+ $this->dieUsage("bad title", 'invalidtitle');
585585
586586 $iw = $titleObj->getInterwiki();
587587 if (!empty($iw)) {
@@ -590,7 +590,7 @@
591591
592592 // Validation
593593 if ($titleObj->getNamespace() < 0)
594 - $this->dieUsage("No support for special page $titleString has been implemented", 'unsupportednamespace');
 594+ $this->dieUsage("No support for special pages has been implemented", 'unsupportednamespace');
595595
596596 $linkBatch->addObj($titleObj);
597597 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r25016Merged revisions 24866-25015 via svnmerge from...david23:06, 21 August 2007

Status & tagging log