r24891 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24890‎ | r24891 | r24892 >
Date:01:35, 18 August 2007
Author:laner
Status:old
Tags:
Comment:
* Changed README to point link to mediawiki.org
* Added a more explicit check in allowPasswordChange for local domains
Modified paths:
  • /trunk/extensions/LdapAuthentication/LdapAuthentication.php (modified) (history)
  • /trunk/extensions/LdapAuthentication/README (modified) (history)

Diff [purge]

Index: trunk/extensions/LdapAuthentication/LdapAuthentication.php
@@ -672,7 +672,8 @@
673673 }
674674
675675 /**
676 - * Can the wiki change passwords in LDAP?
 676+ * Can the wiki change passwords in LDAP, or can the user
 677+ * change passwords locally?
677678 * Return true if yes.
678679 *
679680 * @return bool
@@ -680,11 +681,12 @@
681682 */
682683 function allowPasswordChange() {
683684 global $wgLDAPUpdateLDAP, $wgLDAPMailPassword;
 685+ global $wgLDAPUseLocal;
684686
685687 $retval = false;
686688
687689 // Local domains need to be able to change passwords
688 - if ( 'local' == $_SESSION['wsDomain'] ) {
 690+ if ( (isset($wgLDAPUseLocal) && $wgLDAPUseLocal) && 'local' == $_SESSION['wsDomain'] ) {
689691 $retval = true;
690692 }
691693
Index: trunk/extensions/LdapAuthentication/README
@@ -1 +1 @@
2 -This authentication plugin allows MediaWiki to use an LDAP store as its user database for authentication, and some authorization. Full functionality and configuration information can be found at: http://meta.wikimedia.org/wiki/LDAP_Authentication
 2+This authentication plugin allows MediaWiki to use an LDAP store as its user database for authentication, and some authorization. Full functionality and configuration information can be found at: http://www.mediawiki.org/wiki/Extension:LDAP_Authentication

Status & tagging log