r24859 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24858‎ | r24859 | r24860 >
Date:20:41, 16 August 2007
Author:robchurch
Status:old
Tags:
Comment:
(bug 7890) Don't list redirects to special pages in Special:BrokenRedirects

There could be some issues here, since a redirect to a special page that doesn't exist *is* "broken", but I don't think we have a clear, clean means of excluding these at present...
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialBrokenRedirects.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialBrokenRedirects.php
@@ -35,7 +35,8 @@
3636 FROM $redirect AS rd
3737 JOIN $page p1 ON (rd.rd_from=p1.page_id)
3838 LEFT JOIN $page AS p2 ON (rd_namespace=p2.page_namespace AND rd_title=p2.page_title )
39 - WHERE p2.page_namespace IS NULL";
 39+ WHERE rd_namespace >= 0
 40+ AND p2.page_namespace IS NULL";
4041 return $sql;
4142 }
4243
Index: trunk/phase3/RELEASE-NOTES
@@ -386,6 +386,7 @@
387387 * Fix syntax error in translations of magic words in Romanian language
388388 * (bug 8737) Fix warnings caused by incorrect use of `/dev/null` when piping
389389 process error output under Windows
 390+* (bug 7890) Don't list redirects to special pages in Special:BrokenRedirects
390391
391392 == API changes since 1.10 ==
392393

Follow-up revisions

RevisionCommit summaryAuthorDate
r24866Merged revisions 24755-24865 via svnmerge from...david23:08, 16 August 2007
r25843* (bug 7890) Special:BrokenRedirects links deleted redirects to a non-existen...rotem04:21, 14 September 2007
r25849Merged revisions 25804-25848 via svnmerge from...david06:54, 14 September 2007

Status & tagging log