r24851 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24850‎ | r24851 | r24852 >
Date:08:42, 16 August 2007
Author:david
Status:old
Tags:
Comment:
finally fixed rootRevision bug. thanks php
Modified paths:
  • /branches/liquidthreads/extensions/LqtExtension.php (modified) (history)
  • /branches/liquidthreads/extensions/LqtModel.php (modified) (history)

Diff [purge]

Index: branches/liquidthreads/extensions/LqtExtension.php
@@ -210,10 +210,7 @@
211211 }
212212
213213 static function permalinkUrlWithDiff( $thread ) {
214 - // TODO, changeObjects should return the thread itself.
215214 $changed_thread = $thread->changeObject();
216 -// $changed_thread = Threads::withId($thread->changeObject());
217 - var_dump($changed_thread);
218215 $curr_rev_id = $changed_thread->rootRevision();
219216 $curr_rev = Revision::newFromTitle( $changed_thread->root()->getTitle(), $curr_rev_id );
220217 $prev_rev = $curr_rev->getPrevious();
Index: branches/liquidthreads/extensions/LqtModel.php
@@ -362,9 +362,8 @@
363363 there was a new revision saved at save time. make it run then make it right.)
364364 */
365365 $rev = Revision::newFromTitle( $this->root()->getTitle() );
366 - $this->double->rootRevision = $rev->getId();
 366+ $this->rootRevision = $rev->getId();
367367
368 -
369368 $this->double = clone $this;
370369 }
371370

Status & tagging log