r24844 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24843‎ | r24844 | r24845 >
Date:22:43, 15 August 2007
Author:robchurch
Status:old
Tags:
Comment:
Document hooks in release notes, too, please. Also tweak some odd whitespace usage.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -269,13 +269,16 @@
270270 'page_random',
271271 'page_touched',
272272 'page_latest',
273 - 'page_len' ) ;
274 - wfRunHooks( 'ArticlePageDataBefore', array( &$this , &$fields ) ) ;
275 - $row = $dbr->selectRow( 'page',
 273+ 'page_len',
 274+ );
 275+ wfRunHooks( 'ArticlePageDataBefore', array( &$this, &$fields ) );
 276+ $row = $dbr->selectRow(
 277+ 'page',
276278 $fields,
277279 $conditions,
278 - 'Article::pageData' );
279 - wfRunHooks( 'ArticlePageDataAfter', array( &$this , &$row ) ) ;
 280+ __METHOD__
 281+ );
 282+ wfRunHooks( 'ArticlePageDataAfter', array( &$this, &$row ) );
280283 return $row ;
281284 }
282285
@@ -1251,7 +1254,7 @@
12521255 }
12531256
12541257 $extraq = ''; // Give extensions a chance to modify URL query on update
1255 - wfRunHooks( 'ArticleUpdateBeforeRedirect', array($this,&$extraq) );
 1258+ wfRunHooks( 'ArticleUpdateBeforeRedirect', array( $this, &$extraq ) );
12561259
12571260 $this->doRedirect( $this->isRedirect( $text ), $sectionanchor, $extraq );
12581261 }
Index: trunk/phase3/RELEASE-NOTES
@@ -175,6 +175,8 @@
176176 * Show edit count in user preferences
177177 * Improved support for audio/video extensions
178178 * (bug 10937) Distinguish overwritten files in upload log
 179+* Introduce 'ArticleUpdateBeforeRedirect' hook; see docs/hooks.txt for more
 180+ information
179181
180182 == Bugfixes since 1.10 ==
181183

Follow-up revisions

RevisionCommit summaryAuthorDate
r24866Merged revisions 24755-24865 via svnmerge from...david23:08, 16 August 2007

Status & tagging log