r24825 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24824‎ | r24825 | r24826 >
Date:15:37, 15 August 2007
Author:robchurch
Status:old
Tags:
Comment:
Mark static methods as such
Modified paths:
  • /trunk/phase3/includes/RecentChange.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/RecentChange.php
@@ -258,7 +258,7 @@
259259 }
260260
261261 # Makes an entry in the database corresponding to an edit
262 - /*static*/ function notifyEdit( $timestamp, &$title, $minor, &$user, $comment,
 262+ public static function notifyEdit( $timestamp, &$title, $minor, &$user, $comment,
263263 $oldId, $lastTimestamp, $bot = "default", $ip = '', $oldSize = 0, $newSize = 0,
264264 $newId = 0)
265265 {
@@ -361,7 +361,7 @@
362362 }
363363
364364 # Makes an entry in the database corresponding to a rename
365 - /*static*/ function notifyMove( $timestamp, &$oldTitle, &$newTitle, &$user, $comment, $ip='', $overRedir = false )
 365+ public static function notifyMove( $timestamp, &$oldTitle, &$newTitle, &$user, $comment, $ip='', $overRedir = false )
366366 {
367367 if ( !$ip ) {
368368 $ip = wfGetIP();
@@ -402,17 +402,17 @@
403403 $rc->save();
404404 }
405405
406 - /* static */ function notifyMoveToNew( $timestamp, &$oldTitle, &$newTitle, &$user, $comment, $ip='' ) {
 406+ public static function notifyMoveToNew( $timestamp, &$oldTitle, &$newTitle, &$user, $comment, $ip='' ) {
407407 RecentChange::notifyMove( $timestamp, $oldTitle, $newTitle, $user, $comment, $ip, false );
408408 }
409409
410 - /* static */ function notifyMoveOverRedirect( $timestamp, &$oldTitle, &$newTitle, &$user, $comment, $ip='' ) {
 410+ public static function notifyMoveOverRedirect( $timestamp, &$oldTitle, &$newTitle, &$user, $comment, $ip='' ) {
411411 RecentChange::notifyMove( $timestamp, $oldTitle, $newTitle, $user, $comment, $ip, true );
412412 }
413413
414414 # A log entry is different to an edit in that previous revisions are
415415 # not kept
416 - /*static*/ function notifyLog( $timestamp, &$title, &$user, $comment, $ip='',
 416+ public static function notifyLog( $timestamp, &$title, &$user, $comment, $ip='',
417417 $type, $action, $target, $logComment, $params )
418418 {
419419 if ( !$ip ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r24866Merged revisions 24755-24865 via svnmerge from...david23:08, 16 August 2007

Status & tagging log