r24781 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r24780‎ | r24781 | r24782 >
Date:09:34, 14 August 2007
Author:proes
Status:old
Tags:
Comment:
Records have the ability to check for setting and getting incorrect attributes. Turning this feature on exposed a bug in OmegaWikiAttributes for the view page. This bug now is solved. The edit page results in more bugs that will be addressed next.
Modified paths:
  • /trunk/extensions/Wikidata/OmegaWiki/OmegaWikiAttributes.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikidata/OmegaWiki/OmegaWikiAttributes.php
——@@ -563,7 +563,7 @@
564564 $t->expressionsStructure = new Structure("expressions", $t->expressionId, $t->expression, $t->expressionMeanings);
565565 $t->expressions = new Attribute("expressions", wfMsg("Expressions"), $t->expressionsStructure);
566566 $t->objectId = new Attribute("objectId", "Object identifier", "object-id");
567 - $t->objectAttributesStructure = new Structure("object-attributes", $t->objectId, $t->textAttributeValues, $t->translatedTextAttributeValues, $t->optionAttributeValues);
 567+ $t->objectAttributesStructure = new Structure("object-attributes", $t->objectId, $t->textAttributeValues, $t->translatedTextAttributeValues, $t->optionAttributeValues, $t->linkAttributeValues);
568568 $t->objectAttributes->setAttributeType($t->objectAttributesStructure);
569569 $t->definedMeaningAttributes->setAttributeType($t->objectAttributesStructure);
570570

Status & tagging log