r24757 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24756‎ | r24757 | r24758 >
Date:19:56, 13 August 2007
Author:brion
Status:old
Tags:
Comment:
don't use unspecific paths in require_once()'s ... they break with default include path, and are also unnecessary under autoloader scheme
Modified paths:
  • /trunk/phase3/maintenance/storage/checkStorage.php (modified) (history)
  • /trunk/phase3/maintenance/storage/resolveStubs.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/storage/resolveStubs.php
@@ -6,7 +6,6 @@
77 $optionsWithArgs = array( 'm' );
88
99 require_once( dirname(__FILE__) . '/../commandLine.inc' );
10 - require_once( 'includes/ExternalStoreDB.php' );
1110
1211 resolveStubs();
1312 }
Index: trunk/phase3/maintenance/storage/checkStorage.php
@@ -8,9 +8,6 @@
99
1010 if ( !defined( 'MEDIAWIKI' ) ) {
1111 require_once( dirname(__FILE__) . '/../commandLine.inc' );
12 - require_once( 'ExternalStore.php' );
13 - require_once( 'ExternalStoreDB.php' );
14 - require_once( 'SpecialImport.php' );
1512
1613 $cs = new CheckStorage;
1714 $fix = isset( $options['fix'] );

Follow-up revisions

RevisionCommit summaryAuthorDate
r24866Merged revisions 24755-24865 via svnmerge from...david23:08, 16 August 2007

Status & tagging log