r24714 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24713‎ | r24714 | r24715 >
Date:22:13, 9 August 2007
Author:raymond
Status:old
Tags:
Comment:
* Fix regressions from r24515:
** unknown variable $cascadeSources, should be $cascadingSources
** unknown PHP function 'array_len' (at least to my XAMPP), replaced with count()
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -1143,9 +1143,9 @@
11441144 $right = ( $right == 'sysop' ) ? 'protect' : $right;
11451145 if( '' != $right && !$user->isAllowed( $right ) ) {
11461146 $pages = '';
1147 - foreach( $cascadeSources as $id => $page )
 1147+ foreach( $cascadingSources as $id => $page )
11481148 $pages .= '* [[:' . $page->getPrefixedText() . "]]\n";
1149 - $errors[] = array( 'cascadeprotected', array_len( $cascadingSources ), $pages );
 1149+ $errors[] = array( 'cascadeprotected', count( $cascadingSources ), $pages );
11501150 }
11511151 }
11521152 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r24755Merged revisions 24694-24754 via svnmerge from...david19:48, 13 August 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r24515userCan changes, which have been done for about 3 weeks. Still TODO includes ...werdna10:19, 1 August 2007

Status & tagging log