r24707 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24706‎ | r24707 | r24708 >
Date:20:00, 9 August 2007
Author:robchurch
Status:old
Tags:
Comment:
(bug 10832) Include user information when viewing a deleted revision
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialUndelete.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialUndelete.php
@@ -604,17 +604,24 @@
605605 $archive = new PageArchive( $this->mTargetObj );
606606 $rev = $archive->getRevision( $timestamp );
607607
608 - $wgOut->setPageTitle( wfMsg( 'undeletepage' ) );
609 - $link = $skin->makeKnownLinkObj( $self, htmlspecialchars( $this->mTargetObj->getPrefixedText() ),
610 - 'target=' . $this->mTargetObj->getPrefixedUrl() );
611 - $wgOut->addHtml( '<p>' . wfMsgHtml( 'undelete-revision', $link,
612 - htmlspecialchars( $wgLang->timeAndDate( $timestamp ) ) ) . '</p>' );
613 -
614608 if( !$rev ) {
615 - $wgOut->addWikiText( wfMsg( 'undeleterevision-missing' ) );
 609+ $wgOut->addWikiTexT( wfMsg( 'undeleterevision-missing' ) );
616610 return;
617611 }
618612
 613+ $wgOut->setPageTitle( wfMsg( 'undeletepage' ) );
 614+
 615+ $link = $skin->makeKnownLinkObj(
 616+ $self,
 617+ htmlspecialchars( $this->mTargetObj->getPrefixedText() ),
 618+ 'target=' . $this->mTargetObj->getPrefixedUrl()
 619+ );
 620+ $time = htmlspecialchars( $wgLang->timeAndDate( $timestamp ) );
 621+ $user = $skin->userLink( $rev->getUser(), $rev->getUserText() )
 622+ . $skin->userToolLinks( $rev->getUser(), $rev->getUserText() );
 623+
 624+ $wgOut->addHtml( '<p>' . wfMsgHtml( 'undelete-revision', $link, $time, $user ) . '</p>' );
 625+
619626 wfRunHooks( 'UndeleteShowRevision', array( $this->mTargetObj, $rev ) );
620627
621628 if( $this->mPreview ) {
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1895,7 +1895,7 @@
18961896 'undeletehistorynoadmin' => 'This article has been deleted. The reason for deletion is
18971897 shown in the summary below, along with details of the users who had edited this page
18981898 before deletion. The actual text of these deleted revisions is only available to administrators.',
1899 -'undelete-revision' => 'Deleted revision of $1 from $2:',
 1899+'undelete-revision' => 'Deleted revision of $1 (as of $2) by $3:',
19001900 'undeleterevision-missing' => 'Invalid or missing revision. You may have a bad link, or the
19011901 revision may have been restored or removed from the archive.',
19021902 'undeletebtn' => 'Restore',
Index: trunk/phase3/RELEASE-NOTES
@@ -169,6 +169,7 @@
170170 * (bug 10826) Added link trail with Cyrillic characters for Mongolian language
171171 * (bug 10859) Introduce 'UserGetImplicitGroups' hook; see docs/hooks.txt for
172172 more information
 173+* (bug 10832) Include user information when viewing a deleted revision
173174
174175 == Bugfixes since 1.10 ==
175176

Follow-up revisions

RevisionCommit summaryAuthorDate
r24755Merged revisions 24694-24754 via svnmerge from...david19:48, 13 August 2007

Status & tagging log