r24702 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24701‎ | r24702 | r24703 >
Date:17:34, 9 August 2007
Author:greg
Status:old
Tags:
Comment:
Multi-insert appeared in Postgres 8.2, not 8.1
Bug #10763.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DatabasePostgres.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DatabasePostgres.php
@@ -694,7 +694,7 @@
695695 $sql = "INSERT INTO $table (" . implode( ',', $keys ) . ') VALUES ';
696696
697697 if ( $multi ) {
698 - if ( $wgDBversion >= 8.1 ) {
 698+ if ( $wgDBversion >= 8.2 ) {
699699 $first = true;
700700 foreach ( $args as $row ) {
701701 if ( $first ) {
Index: trunk/phase3/RELEASE-NOTES
@@ -372,8 +372,8 @@
373373 disable user setting of PHP include_path setting
374374 * glob() is horribly unreliable and doesn't work on some systems, including
375375 free.fr shared hosting. No longer using it in Language::getLanguageNames()
 376+* (bug 10763) Fix multi-insert logic for Postgres.
376377
377 -
378378 == API changes since 1.10 ==
379379
380380 Full API documentation is available at http://www.mediawiki.org/wiki/API

Follow-up revisions

RevisionCommit summaryAuthorDate
r24755Merged revisions 24694-24754 via svnmerge from...david19:48, 13 August 2007

Status & tagging log