r24687 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24686‎ | r24687 | r24688 >
Date:18:37, 8 August 2007
Author:rotem
Status:old
Tags:
Comment:
Adding direction marks between the edit comments and the page name in the contributions and logs pages, to prevent problems when the direction of both is not the direction of the site (e.g. RTL site, LTR page name and edit comment).
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialContributions.php (modified) (history)
  • /trunk/phase3/includes/SpecialLog.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialContributions.php
@@ -143,7 +143,7 @@
144144 function formatRow( $row ) {
145145 wfProfileIn( __METHOD__ );
146146
147 - global $wgLang, $wgUser;
 147+ global $wgLang, $wgUser, $wgContLang;
148148
149149 $sk = $this->getSkin();
150150 $rev = new Revision( $row );
@@ -171,7 +171,7 @@
172172 }
173173 $histlink='('.$sk->makeKnownLinkObj( $page, $this->messages['hist'], 'action=history' ) . ')';
174174
175 - $comment = $sk->revComment( $rev );
 175+ $comment = $wgContLang->getDirMark() . $sk->revComment( $rev );
176176 $d = $wgLang->timeanddate( wfTimestamp( TS_MW, $row->rev_timestamp ), true );
177177
178178 if( $this->target == 'newbies' ) {
Index: trunk/phase3/includes/SpecialLog.php
@@ -350,7 +350,7 @@
351351 * @private
352352 */
353353 function logLine( $s ) {
354 - global $wgLang, $wgUser;;
 354+ global $wgLang, $wgUser, $wgContLang;
355355 $skin = $wgUser->getSkin();
356356 $title = Title::makeTitle( $s->log_namespace, $s->log_title );
357357 $time = $wgLang->timeanddate( wfTimestamp(TS_MW, $s->log_timestamp), true );
@@ -365,7 +365,7 @@
366366 }
367367
368368 $userLink = $this->skin->userLink( $s->log_user, $s->user_name ) . $this->skin->userToolLinksRedContribs( $s->log_user, $s->user_name );
369 - $comment = $this->skin->commentBlock( $s->log_comment );
 369+ $comment = $wgContLang->getDirMark() . $this->skin->commentBlock( $s->log_comment );
370370 $paramArray = LogPage::extractParams( $s->log_params );
371371 $revert = '';
372372 // show revertmove link
Index: trunk/phase3/RELEASE-NOTES
@@ -366,6 +366,7 @@
367367 sort keys to work on Safari
368368 * (bug 4530) Fix local name of Kurdish language
369369 * (bug 10830) Fix local name Haitian Creole language
 370+* Fix comments in contributions and log pages for RTL languages
370371
371372 == API changes since 1.10 ==
372373

Follow-up revisions

RevisionCommit summaryAuthorDate
r24705Merged revisions 24632-24693 via svnmerge from...david19:15, 9 August 2007

Status & tagging log