r24640 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24639‎ | r24640 | r24641 >
Date:01:20, 7 August 2007
Author:rotem
Status:old
Tags:
Comment:
Fixed a display problem in the E-mail part of the preferences page when the E-mail is not confirmed: the notice about it was in the same line as a preference.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialPreferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialPreferences.php
@@ -558,7 +558,7 @@
559559 $skin = $wgUser->getSkin();
560560 $emailauthenticated = wfMsg('emailnotauthenticated').'<br />' .
561561 $skin->makeKnownLinkObj( SpecialPage::getTitleFor( 'Confirmemail' ),
562 - wfMsg( 'emailconfirmlink' ) );
 562+ wfMsg( 'emailconfirmlink' ) ) . '<br />';
563563 }
564564 } else {
565565 $emailauthenticated = '';
@@ -566,7 +566,7 @@
567567 }
568568
569569 if ($this->mUserEmail == '') {
570 - $emailauthenticated = wfMsg( 'noemailprefs' );
 570+ $emailauthenticated = wfMsg( 'noemailprefs' ) . '<br />';
571571 }
572572
573573 $ps = $this->namespacesCheckboxes();
Index: trunk/phase3/RELEASE-NOTES
@@ -362,6 +362,9 @@
363363 * (bug 10765) img_auth.php will now refuse logged-out requests where
364364 $wgWhitelistRead is undefined, instead of (incorrectly) honouring them
365365 * Fixed img_auth.php file name extraction for whitelist checking
 366+* Fixed a display problem in the E-mail part of the preferences page when
 367+ the E-mail is not confirmed: the notice about it was in the same line as
 368+ a preference.
366369
367370 == API changes since 1.10 ==
368371

Follow-up revisions

RevisionCommit summaryAuthorDate
r24705Merged revisions 24632-24693 via svnmerge from...david19:15, 9 August 2007

Status & tagging log