r24604 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24603‎ | r24604 | r24605 >
Date:06:45, 5 August 2007
Author:mkroetzsch
Status:old
Tags:
Comment:
Normalise unspecified page ids to "false" internally
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_DV_WikiPage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/SMW_DV_WikiPage.php
@@ -2,7 +2,7 @@
33 /**
44 * This datavalue implements special processing suitable for defining
55 * wikipages as values of properties. This value container currently
6 - * behaves somewhat special in that its xsdvalue is not containint all
 6+ * behaves somewhat special in that its xsdvalue is not contained all
77 * relevant information (it just gives the DB-Key, not the namespace).
88 * TODO: This should change, but is not really critical now.
99 *
@@ -204,7 +204,7 @@
205205 public function setValues($dbkey, $namespace, $id = false) {
206206 $this->m_namespace = $namespace;
207207 $this->setXSDValue($dbkey);
208 - $this->m_id = $id;
 208+ $this->m_id = $id ? $id : false;
209209 }
210210
211211 ///// Legacy methods for compatibility

Status & tagging log