r24575 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24574‎ | r24575 | r24576 >
Date:12:38, 4 August 2007
Author:robchurch
Status:old
Tags:
Comment:
This is a public service announcement. When using entities, failure to terminate them in a semi colon will result in XHTML validation errors. Can all developers please do us the basic favour of a bit of XHTML validation on their generated markup? This has been a public service announcement by the Frobozz XHTML Validation Company. Reach out and specify somebody.
Modified paths:
  • /trunk/phase3/includes/SpecialProtectedpages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialProtectedpages.php
@@ -110,12 +110,12 @@
111111 return "<form action=\"$action\" method=\"get\">\n" .
112112 '<fieldset>' .
113113 Xml::element( 'legend', array(), wfMsg( 'protectedpages' ) ) .
114 - Xml::hidden( 'title', $special ) . "&nbsp\n" .
115 - $this->getNamespaceMenu( $namespace ) . "&nbsp\n" .
116 - $this->getTypeMenu( $type ) . "&nbsp\n" .
 114+ Xml::hidden( 'title', $special ) . "&nbsp;\n" .
 115+ $this->getNamespaceMenu( $namespace ) . "&nbsp;\n" .
 116+ $this->getTypeMenu( $type ) . "&nbsp;\n" .
117117 $this->getLevelMenu( $level ) . "<br/>\n" .
118118 $this->getSizeLimit( $sizetype, $size ) . "\n" .
119 - "&nbsp" . Xml::submitButton( wfMsg( 'allpagessubmit' ) ) . "\n" .
 119+ "&nbsp;" . Xml::submitButton( wfMsg( 'allpagessubmit' ) ) . "\n" .
120120 "</fieldset></form>";
121121 }
122122
@@ -139,9 +139,9 @@
140140 function getSizeLimit( $sizetype, $size ) {
141141 $out = Xml::radio( 'sizetype', 'min', ($sizetype=='min'), array('id' => 'wpmin') );
142142 $out .= Xml::label( wfMsg("minimum-size"), 'wpmin' );
143 - $out .= "&nbsp".Xml::radio( 'sizetype', 'max', ($sizetype=='max'), array('id' => 'wpmax') );
 143+ $out .= "&nbsp;".Xml::radio( 'sizetype', 'max', ($sizetype=='max'), array('id' => 'wpmax') );
144144 $out .= Xml::label( wfMsg("maximum-size"), 'wpmax' );
145 - $out .= "&nbsp".Xml::input('size', 9, $size, array( 'id' => 'wpsize' ) );
 145+ $out .= "&nbsp;".Xml::input('size', 9, $size, array( 'id' => 'wpsize' ) );
146146 $out .= ' '.wfMsgHtml('pagesize');
147147 return $out;
148148 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r24631Merged revisions 24480-24600 via svnmerge from...david18:39, 6 August 2007

Status & tagging log