r24556 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24555‎ | r24556 | r24557 >
Date:06:26, 3 August 2007
Author:aaron
Status:old
Tags:
Comment:
*Fix errors for mysql strict mode
Modified paths:
  • /trunk/extensions/ConfirmAccount/ConfirmAccount.sql (modified) (history)
  • /trunk/extensions/ConfirmAccount/ConfirmAccount_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmAccount/ConfirmAccount.sql
@@ -28,11 +28,11 @@
2929 -- Expiration date for the user_email_token
3030 acr_email_token_expires binary(14),
3131 -- A little about this user
32 - acr_bio mediumblob default '',
 32+ acr_bio mediumblob NOT NULL,
3333 -- Private info for reviewers to look at when considering request
34 - acr_notes mediumblob default '',
 34+ acr_notes mediumblob NOT NULL,
3535 -- Links to recognize/identify this user, CSV, may not be public
36 - acr_urls mediumblob default '',
 36+ acr_urls mediumblob NOT NULL,
3737 -- IP address
3838 acr_ip VARCHAR(255) NULL default '',
3939
Index: trunk/extensions/ConfirmAccount/ConfirmAccount_body.php
@@ -34,9 +34,9 @@
3535 # Grab other info fields...
3636 $this->mRealName = $wgRequest->getText( 'wpRealName' );
3737 $this->mEmail = $wgRequest->getText( 'wpEmail' );
38 - $this->mBio = $wgRequest->getText( 'wpBio' );
39 - $this->mNotes = $wgRequest->getText( 'wpNotes' );
40 - $this->mUrls = $wgRequest->getText( 'wpUrls' );
 38+ $this->mBio = $wgRequest->getText( 'wpBio', '' );
 39+ $this->mNotes = $wgRequest->getText( 'wpNotes', '' );
 40+ $this->mUrls = $wgRequest->getText( 'wpUrls', '' );
4141 $this->mCorrect = $wgRequest->getBool('wpCorrect');
4242 $this->mToS = $wgRequest->getBool('wpToS');
4343 # We may be confirming an email address here

Status & tagging log