r2455 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r2454‎ | r2455 | r2456 >
Date:08:05, 8 February 2004
Author:timstarling
Status:old
Tags:
Comment:
bug fix -- htmlspecialchars in thumbnail markup
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -1597,7 +1597,9 @@
15981598 $link = $image->getPrefixedURL();
15991599 $url = wfImageUrl( $name );
16001600 $path = wfImagePath( $name );
1601 -
 1601+
 1602+ $label = htmlspecialchars( $label );
 1603+
16021604 list($width, $height, $type, $attr) = getimagesize( $path );
16031605 $cwidth = $boxwidth;
16041606 $cheight = intval( $height/($width/$cwidth) );

Status & tagging log