r24547 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r24546
|
r24547
|
r24548
>
Date:
00:00, 3 August 2007
Author:
rotem
Status:
old
Tags:
Comment:
I guess it should actually return the result (anyway, there is a fatal PHP error when the folder was not writable without this fix, rather than a valid error shown to the user like now).
Modified paths:
/trunk/phase3/includes/filerepo/FileRepoStatus.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/phase3/includes/filerepo/FileRepoStatus.php
—
—
@@ -22,6 +22,7 @@
23
23
$result = new self( $repo );
24
24
call_user_func_array( array( &$result, 'error' ), $params );
25
25
$result->ok = false;
26
+ return $result;
26
27
}
27
28
28
29
static function newGood( $repo = false, $value = null ) {
Follow-up revisions
Revision
Commit summary
Author
Date
r24631
Merged revisions 24480-24600 via svnmerge from...
david
18:39, 6 August 2007
Status & tagging log
15:20, 12 September 2011
Meno25
(
talk
|
contribs
)
changed the
status
of r24547
[
removed:
ok
added:
old]