r24442 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24441‎ | r24442 | r24443 >
Date:23:37, 29 July 2007
Author:brion
Status:old
Tags:
Comment:
fix an immediate php error, but result is still wrong -- we get 'exif-exif-make' etc, since the tag already has 'exif' in the name. Something's broken, but not sure where
Modified paths:
  • /trunk/phase3/includes/media/Bitmap.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/media/Bitmap.php
@@ -274,7 +274,7 @@
275275 // Sort fields into visible and collapsed
276276 $visibleFields = $this->visibleMetadataFields();
277277 foreach ( $formatted as $name => $value ) {
278 - $tag = strtolower( $k );
 278+ $tag = strtolower( $name );
279279 self::addMeta( $result,
280280 in_array( $tag, $visibleFields ) ? 'visible' : 'collapsed',
281281 'exif',

Follow-up revisions

RevisionCommit summaryAuthorDate
r24502Merged revisions 24415-24479 via svnmerge from...david22:31, 31 July 2007

Status & tagging log