r24424 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24423‎ | r24424 | r24425 >
Date:02:18, 29 July 2007
Author:rotem
Status:old
Tags:
Comment:
A message (fileexists) with the same name of another one was introduced in r24313; renaming it to fileexistserror. Other messages files that updated since this revision may also have to rename the message.
Modified paths:
  • /trunk/phase3/includes/filerepo/FSRepo.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesHe.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -304,7 +304,7 @@
305305 'filedeleteerror',
306306 'directorycreateerror',
307307 'filenotfound',
308 - 'fileexists',
 308+ 'fileexistserror',
309309 'unexpected',
310310 'formerror',
311311 'badarticleerror',
Index: trunk/phase3/includes/filerepo/FSRepo.php
@@ -166,10 +166,10 @@
167167 $hashSource = sha1_file( $srcPath );
168168 $hashDest = sha1_file( $dstPath );
169169 if ( $hashSource != $hashDest ) {
170 - $status->fatal( 'fileexists', $dstPath );
 170+ $status->fatal( 'fileexistserror', $dstPath );
171171 }
172172 } else {
173 - $status->fatal( 'fileexists', $dstPath );
 173+ $status->fatal( 'fileexistserror', $dstPath );
174174 }
175175 }
176176 }
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -767,7 +767,7 @@
768768 'filedeleteerror' => 'Could not delete file "$1".',
769769 'directorycreateerror' => 'Could not create directory "$1".',
770770 'filenotfound' => 'Could not find file "$1".',
771 -'fileexists' => 'Unable to write to file "$1": file exists',
 771+'fileexistserror' => 'Unable to write to file "$1": file exists',
772772 'unexpected' => 'Unexpected value: "$1"="$2".',
773773 'formerror' => 'Error: could not submit form',
774774 'badarticleerror' => 'This action cannot be performed on this page.',
Index: trunk/phase3/languages/messages/MessagesHe.php
@@ -505,7 +505,7 @@
506506 'filedeleteerror' => 'מחיקת "$1" נכשלה.',
507507 'directorycreateerror' => 'יצירת התיקייה "$1" נכשלה.',
508508 'filenotfound' => 'הקובץ "$1" לא נמצא.',
509 -'fileexists' => 'הכתיבה לקובץ "$1" נכשלה: הקובץ קיים',
 509+'fileexistserror' => 'הכתיבה לקובץ "$1" נכשלה: הקובץ קיים',
510510 'unexpected' => 'ערך לא צפוי: "$1"="$2"',
511511 'formerror' => 'שגיאה: לא יכול לשלוח טופס.',
512512 'badarticleerror' => 'לא ניתן לבצע פעולה זו בדף זה.',

Follow-up revisions

RevisionCommit summaryAuthorDate
r24502Merged revisions 24415-24479 via svnmerge from...david22:31, 31 July 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r24313* Introduced FileRepoStatus -- result class for file repo operations....tstarling14:45, 22 July 2007

Status & tagging log