r24281 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24280‎ | r24281 | r24282 >
Date:03:29, 20 July 2007
Author:aaron
Status:old
Tags:
Comment:
*Tinker with CSS, give more message room, shrink amount of text, also, add a label to namespace selector.
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevsPage.i18n.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevsPage_body.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/flaggedrevs.css (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -393,7 +393,7 @@
394394 # Get quality level
395395 $quality = self::isQuality( $flags );
396396 $pristine = self::isPristine( $flags );
397 - $time = $wgLang->timeanddate( wfTimestamp(TS_MW, $tfrev->fr_timestamp), true );
 397+ $time = $wgLang->date( wfTimestamp(TS_MW, $tfrev->fr_timestamp), true );
398398
399399 $skin = $wgUser->getSkin();
400400 // Some checks for which tag CSS to use
@@ -856,7 +856,7 @@
857857 # Get quality level
858858 $quality = parent::isQuality( $flags );
859859 $pristine = parent::isPristine( $flags );
860 - $time = $wgLang->timeanddate( wfTimestamp(TS_MW, $tfrev->fr_timestamp), true );
 860+ $time = $wgLang->date( wfTimestamp(TS_MW, $tfrev->fr_timestamp), true );
861861 # Looking at some specific old rev or if flagged revs override only for anons
862862 if( !$this->pageOverride() ) {
863863 $revs_since = parent::getRevCountSince( $pageid, $tfrev->fr_rev_id );
@@ -969,7 +969,7 @@
970970 $tfrev = $this->getOverridingRev();
971971 if( is_object($tfrev) ) {
972972 global $wgLang;
973 - $time = $wgLang->timeanddate( wfTimestamp(TS_MW, $tfrev->fr_timestamp), true );
 973+ $time = $wgLang->date( wfTimestamp(TS_MW, $tfrev->fr_timestamp), true );
974974 $flags = $this->getFlagsForRevision( $tfrev->fr_rev_id );
975975 $revs_since = parent::getRevCountSince( $editform->mArticle->getID(), $tfrev->fr_rev_id );
976976 # Construct some tagging
Index: trunk/extensions/FlaggedRevs/flaggedrevs.css
@@ -1,10 +1,10 @@
22 .flaggedrevs_tag1 {
33 border: 1px solid #aaa;
44 background-color: #f0f8ff;
5 - padding: 5px;
 5+ padding: 3px;
66 font-size: 80%;
7 - margin-left: 5px;
8 - margin-right: 5px;
 7+ margin-left: 0px;
 8+ margin-right: 0px;
99 text-align: center;
1010 }
1111
@@ -13,28 +13,28 @@
1414 background-color: #f0fff0;
1515 padding: 5px;
1616 font-size: 80%;
17 - margin-left: 5px;
18 - margin-right: 5px;
 17+ margin-left: 0px;
 18+ margin-right: 0px;
1919 text-align: center;
2020 }
2121
2222 .flaggedrevs_tag3 {
2323 border: 1px solid #aaa;
2424 background-color: #fffff0;
25 - padding: 5px;
 25+ padding: 3px;
2626 font-size: 80%;
27 - margin-left: 5px;
28 - margin-right: 5px;
 27+ margin-left: 0px;
 28+ margin-right: 0px;
2929 text-align: center;
3030 }
3131
3232 .flaggedrevs_notice {
3333 border: 1px solid #aaa;
3434 background-color: #f9f9f9;
35 - padding: 5px;
 35+ padding: 3px;
3636 font-size: 80%;
37 - margin-left: 5px;
38 - margin-right: 5px;
 37+ margin-left: 0px;
 38+ margin-right: 0px;
3939 text-align: center;
4040 }
4141
Index: trunk/extensions/FlaggedRevs/FlaggedRevsPage_body.php
@@ -691,6 +691,7 @@
692692 $action = htmlspecialchars( $wgScript );
693693 $wgOut->addHTML( "<form action=\"$action\" method=\"get\">\n" .
694694 '<fieldset><legend>' . wfMsg('viewunreviewed') . '</legend>' .
 695+ Xml::label( wfMsgHtml("namespace"), 'namespace' ) . ' ' .
695696 $this->getNamespaceMenu( $namespace ) . "\n" .
696697 Xml::submitButton( wfMsg( 'allpagessubmit' ) ) . "\n" .
697698 '<p>' . Xml::check( 'includenonquality', $nonquality, array('id' => 'includenonquality') ) .
Index: trunk/extensions/FlaggedRevs/FlaggedRevsPage.i18n.php
@@ -28,23 +28,23 @@
2929 ($2 [{{fullurl:{{FULLPAGENAMEE}}|oldid=$1&diff=cur}} {{plural:$2|change|changes}}])',
3030 'revreview-quick-none' => '\'\'\'Current\'\'\'. No reviewed revisions.',
3131 'revreview-newest-basic' => 'The [{{fullurl:{{FULLPAGENAMEE}}|stable=1}} latest sighted revision]
32 - ([{{fullurl:Special:Stableversions|page={{FULLPAGENAMEE}}}} see all]) of this page was [{{fullurl:Special:Log|type=review&page={{FULLPAGENAMEE}}}} approved]
33 - on <i>$2</i>. <br/> There {{plural:$3|is|are}} [{{fullurl:{{FULLPAGENAMEE}}|oldid=$1&diff=cur}} $3 {{plural:$3|revision|revisions}}] awaiting review.',
 32+ ([{{fullurl:Special:Stableversions|page={{FULLPAGENAMEE}}}} list all]) was [{{fullurl:Special:Log|type=review&page={{FULLPAGENAMEE}}}} approved]
 33+ on <i>$2</i>. [{{fullurl:{{FULLPAGENAMEE}}|oldid=$1&diff=cur}} $3 {{plural:$3|revision|revisions}}] {{plural:$3|needs|need}} review.',
3434 'revreview-newest-quality' => 'The [{{fullurl:{{FULLPAGENAMEE}}|stable=1}} latest quality revision]
35 - ([{{fullurl:Special:Stableversions|page={{FULLPAGENAMEE}}}} see all]) of this page was [{{fullurl:Special:Log|type=review&page={{FULLPAGENAMEE}}}} approved]
36 - on <i>$2</i>. <br/> There {{plural:$3|is|are}} [{{fullurl:{{FULLPAGENAMEE}}|oldid=$1&diff=cur}} $3 {{plural:$3|revision|revisions}}] awaiting review.',
37 - 'revreview-basic' => 'This is the latest [[Help:Article validation|sighted]] revision of this page,
38 - [{{fullurl:Special:Log|type=review&page={{FULLPAGENAMEE}}}} approved] on <i>$2</i>. The [{{fullurl:{{FULLPAGENAMEE}}|stable=0}} current revision]
39 - is usually [{{fullurl:{{FULLPAGENAMEE}}|action=edit}} editable]. There {{plural:$3|is|are}} [{{fullurl:{{FULLPAGENAMEE}}|oldid=$1&diff=cur}}
40 - $3 {{plural:$3|revision|revisions}}] awaiting review.',
41 - 'revreview-quality' => 'This is the latest [[Help:Article validation|quality]] revision of this page,
42 - [{{fullurl:Special:Log|type=review&page={{FULLPAGENAMEE}}}} approved] on <i>$2</i>. The [{{fullurl:{{FULLPAGENAMEE}}|stable=0}} current revision]
43 - is usually [{{fullurl:{{FULLPAGENAMEE}}|action=edit}} editable]. There {{plural:$3|is|are}}
44 - [{{fullurl:{{FULLPAGENAMEE}}|oldid=$1&diff=cur}} $3 {{plural:$3|revision|revisions}}] awaiting review.',
 35+ ([{{fullurl:Special:Stableversions|page={{FULLPAGENAMEE}}}} list all]) was [{{fullurl:Special:Log|type=review&page={{FULLPAGENAMEE}}}} approved]
 36+ on <i>$2</i>. [{{fullurl:{{FULLPAGENAMEE}}|oldid=$1&diff=cur}} $3 {{plural:$3|revision|revisions}}] {{plural:$3|needs|need}} review.',
 37+ 'revreview-basic' => 'This is the latest [[Help:Article validation|sighted]] revision,
 38+ [{{fullurl:Special:Log|type=review&page={{FULLPAGENAMEE}}}} approved] on <i>$2</i>. The [{{fullurl:{{FULLPAGENAMEE}}|stable=0}} current one]
 39+ can be [{{fullurl:{{FULLPAGENAMEE}}|action=edit}} modified]; [{{fullurl:{{FULLPAGENAMEE}}|oldid=$1&diff=cur}} $3 {{plural:$3|revision|revisions}}]
 40+ {{plural:$3|awaits|await}} review.',
 41+ 'revreview-quality' => 'This is the latest [[Help:Article validation|quality]] revision,
 42+ [{{fullurl:Special:Log|type=review&page={{FULLPAGENAMEE}}}} approved] on <i>$2</i>. The [{{fullurl:{{FULLPAGENAMEE}}|stable=0}} current one]
 43+ can be [{{fullurl:{{FULLPAGENAMEE}}|action=edit}} modified]; [{{fullurl:{{FULLPAGENAMEE}}|oldid=$1&diff=cur}} $3 {{plural:$3|revision|revisions}}]
 44+ {{plural:$3|awaits|await}} review.',
4545 'revreview-static' => 'This is a [[Help:Article validation|reviewed]] revision of \'\'\'[[:$3|this page]]\'\'\',
4646 [{{fullurl:Special:Log/review|page=$1}} approved] on <i>$2</i>. The [{{fullurl:$3|stable=0}} current revision]
4747 is usually editable and more up to date.',
48 - 'revreview-toggle' => '(toggle details)',
 48+ 'revreview-toggle' => '(details)',
4949 'revreview-note' => '[[User:$1]] made the following notes [[Help:Article validation|reviewing]] this revision:',
5050
5151 'hist-stable' => '[sighted]',

Status & tagging log