r24246 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24245‎ | r24246 | r24247 >
Date:18:56, 18 July 2007
Author:aaron
Status:old
Tags:
Comment:
*Message cleanup
Modified paths:
  • /trunk/extensions/ConfirmAccount/ConfirmAccount.i18n.php (modified) (history)
  • /trunk/extensions/ConfirmAccount/ConfirmAccount_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmAccount/ConfirmAccount_body.php
@@ -419,10 +419,10 @@
420420 if( !$row->acr_rejected ) {
421421 if( $this->reason ) {
422422 $result = $u->sendMail( wfMsg( 'confirmaccount-email-subj' ),
423 - wfMsg( 'confirmaccount-email-body4', $u->getName(), $this->reason ) );
 423+ wfMsgExt( 'confirmaccount-email-body4', array('parseinline'), $u->getName(), $this->reason ) );
424424 } else {
425425 $result = $u->sendMail( wfMsg( 'confirmaccount-email-subj' ),
426 - wfMsg( 'confirmaccount-email-body3', $u->getName() ) );
 426+ wfMsgExt( 'confirmaccount-email-body3', array('parseinline'), $u->getName() ) );
427427 }
428428 if( WikiError::isError( $result ) ) {
429429 $error = wfMsg( 'mailerror', htmlspecialchars( $result->getMessage() ) );
@@ -461,28 +461,28 @@
462462 }
463463 $user = User::createNew( $name );
464464 # Make a random password
465 - $pass = User::randomPassword();
 465+ $p = User::randomPassword();
466466 # VERY important to set email now. Otherwise user will have to request
467467 # a new password at the login screen...
468468 $user->setEmail( $row->acr_email );
469469 if( $this->reason ) {
470470 $result = $user->sendMail( wfMsg( 'confirmaccount-email-subj' ),
471 - wfMsg( 'confirmaccount-email-body2', $user->getName(), $pass, $this->reason ) );
 471+ wfMsgExt( 'confirmaccount-email-body2', array('parseinline'), $user->getName(), $p, $this->reason ) );
472472 } else {
473473 $result = $user->sendMail( wfMsg( 'confirmaccount-email-subj' ),
474 - wfMsg( 'confirmaccount-email-body', $user->getName(), $pass ) );
 474+ wfMsgExt( 'confirmaccount-email-body', array('parseinline'), $user->getName(), $p ) );
475475 }
476476 if( WikiError::isError( $result ) ) {
477477 $error = wfMsg( 'mailerror', htmlspecialchars( $result->getMessage() ) );
478478 $this->showForm( $error );
479479 return false;
480480 }
481 - if( !$wgAuth->addUser( $user, $pass, $row->acr_email, $row->acr_real_name ) ) {
 481+ if( !$wgAuth->addUser( $user, $p, $row->acr_email, $row->acr_real_name ) ) {
482482 $this->showForm( wfMsgHtml( 'externaldberror' ) );
483483 return false;
484484 }
485485 # Set password and realname
486 - $user->setPassword( $pass );
 486+ $user->setPassword( $p );
487487 $user->setRealName( $row->acr_real_name );
488488 $user->saveSettings(); // Save this into the DB
489489 # Check if the user already confirmed email address
Index: trunk/extensions/ConfirmAccount/ConfirmAccount.i18n.php
@@ -99,8 +99,11 @@
100100
101101 Password: $2
102102
103 -You may have been granted a slightly different name than requested. This could be due to name collisions
104 -or policy reasons. Also, please immediatly login, go to your preferences options, and set a new password.',
 103+If you have been granted a slightly different name than requested, this could be due to name collisions
 104+or policy reasons.
 105+
 106+For security reasons you will need to change your password on first login. To login, please go to
 107+{{fullurl:Special:Userlogin}}.',
105108 'confirmaccount-email-body2' => 'Your request for an account has been approved on {{SITENAME}}.
106109
107110 Account name: $1
@@ -109,8 +112,11 @@
110113
111114 $3
112115
113 -You may have been granted a slightly different name than requested. This could be due to name collisions
114 -or policy reasons. Also, please immediatly login, go to your preferences options, and set a new password.',
 116+If you have been granted a slightly different name than requested, this could be due to name collisions
 117+or policy reasons.
 118+
 119+For security reasons you will need to change your password on first login. To login, please go to
 120+{{fullurl:Special:Userlogin}}.',
115121 'confirmaccount-email-body3' => 'Sorry, your request for an account "$1" has been rejected on {{SITENAME}}.
116122
117123 There are several ways this can happen. You may not have filled out the form correctly, did not provide adequate

Status & tagging log