r24231 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24230‎ | r24231 | r24232 >
Date:08:54, 18 July 2007
Author:aaron
Status:old
Tags:
Comment:
*Reword variable in a slight anal-retentive fashion
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -617,38 +617,38 @@
618618 return true;
619619 }
620620
621 - public static function extraLinksUpdate( &$linkUpdate ) {
 621+ public static function extraLinksUpdate( &$linksUpdate ) {
622622 $fname = 'FlaggedRevs::extraLinksUpdate';
623623 wfProfileIn( $fname );
624624
625 - if( !$linkUpdate->mTitle->isContentPage() )
 625+ if( !$linksUpdate->mTitle->isContentPage() )
626626 return true;
627627 # Check if this page has a stable version
628 - $sv = self::getOverridingPageRev( $linkUpdate->mTitle );
 628+ $sv = self::getOverridingPageRev( $linksUpdate->mTitle );
629629 if( !$sv )
630630 return true;
631631 # Retrieve the text
632632 $text = self::getFlaggedRevText( $sv->fr_rev_id );
633633 # Parse the revision
634634 $options = new ParserOptions;
635 - $parserOutput = self::parseStableText( $linkUpdate->mTitle, $text, $sv->fr_rev_id, $options );
 635+ $parserOutput = self::parseStableText( $linksUpdate->mTitle, $text, $sv->fr_rev_id, $options );
636636 # Might as well update the cache while we're at it
637 - $article = new Article( $linkUpdate->mTitle );
 637+ $article = new Article( $linksUpdate->mTitle );
638638 FlaggedRevs::updatePageCache( $article, $parserOutput );
639639 # Update the links tables to include these
640640 # We want the UNION of links between the current
641641 # and stable version. Therefore, we only care about
642642 # links that are in the stable version and not the regular one.
643 - $linkUpdate->mLinks += $parserOutput->getLinks();
644 - $linkUpdate->mImages += $parserOutput->getImages();
645 - $linkUpdate->mTemplates += $parserOutput->getTemplates();
646 - $linkUpdate->mExternals += $parserOutput->getExternalLinks();
647 - $linkUpdate->mCategories += $parserOutput->getCategories();
 643+ $linksUpdate->mLinks += $parserOutput->getLinks();
 644+ $linksUpdate->mImages += $parserOutput->getImages();
 645+ $linksUpdate->mTemplates += $parserOutput->getTemplates();
 646+ $linksUpdate->mExternals += $parserOutput->getExternalLinks();
 647+ $linksUpdate->mCategories += $parserOutput->getCategories();
648648 # Interlanguage links
649649 $ill = $parserOutput->getLanguageLinks();
650650 foreach( $ill as $link ) {
651651 list( $key, $title ) = explode( ':', $link, 2 );
652 - $linkUpdate->mInterlangs[$key] = $title;
 652+ $linksUpdate->mInterlangs[$key] = $title;
653653 }
654654
655655 wfProfileOut( $fname );

Status & tagging log