r24208 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24207‎ | r24208 | r24209 >
Date:17:45, 17 July 2007
Author:brion
Status:old
Tags:
Comment:
bug 10594 -- @import needs to be at the start of the <style> due to anal spec
Modified paths:
  • /trunk/extensions/SyntaxHighlight_GeSHi/SyntaxHighlight_GeSHi.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SyntaxHighlight_GeSHi/SyntaxHighlight_GeSHi.class.php
@@ -130,13 +130,16 @@
131131 $css[] = ".source-$lang {line-height: normal;}";
132132 $css[] = ".source-$lang li {line-height: normal;}";
133133 $css[] = $geshi->get_stylesheet( false );
 134+ $css[] = '/*]]>*/';
 135+ $css[] = '</style>';
134136 if( $wgUseSiteCss ) {
135137 $title = Title::makeTitle( NS_MEDIAWIKI, 'Geshi.css' );
136138 $q = "usemsgcache=yes&action=raw&ctype=text/css&smaxage={$wgSquidMaxage}";
 139+ $css[] = '<style type="text/css">/*<![CDATA[*/';
137140 $css[] = '@import "' . $title->getLocalUrl( $q ) . '";';
 141+ $css[] = '/*]]>*/';
 142+ $css[] = '</style>';
138143 }
139 - $css[] = '/*]]>*/';
140 - $css[] = '</style>';
141144 return implode( "\n", $css );
142145 }
143146

Status & tagging log