r24190 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24189‎ | r24190 | r24191 >
Date:03:46, 17 July 2007
Author:avar
Status:old
Tags:
Comment:
ok 0 => msg ==> fail(msg) ; ok 1 => msg ==> pass(msg)
Modified paths:
  • / (modified) (history)
  • /trunk/phase3/t/maint/bom.t (modified) (history)
  • /trunk/phase3/t/maint/eol-style.t (modified) (history)
  • /trunk/phase3/t/maint/php-tag.t (modified) (history)
  • /trunk/phase3/t/maint/unix-newlines.t (modified) (history)

Diff [purge]

Index: trunk/phase3/t/maint/bom.t
@@ -32,8 +32,8 @@
3333 for my $file (@files) {
3434 my $content = slurp $file ;
3535 if( $content =~ /$bomchar/ ) {
36 - ok 0 => "$file got a Byte Order Mark";
 36+ fail "$file got a Byte Order Mark";
3737 } else {
38 - ok 1 => "$file BOM less";
 38+ pass "$file BOM less";
3939 }
4040 }
Index: trunk/phase3/t/maint/eol-style.t
@@ -26,10 +26,10 @@
2727 waitpid $pid, 0;
2828
2929 if ( $? != 0 ) {
30 - ok 1 => "svn propget failed, $file probably not under version control";
 30+ pass "svn propget failed, $file probably not under version control";
3131 } elsif ( $res eq 'native' ) {
32 - ok 1 => "$file svn:eol-style is 'native'";
 32+ pass "$file svn:eol-style is 'native'";
3333 } else {
34 - ok 0 => "$file svn:eol-style is '$res', should be 'native'";
 34+ fail "$file svn:eol-style is '$res', should be 'native'";
3535 }
3636 }
Index: trunk/phase3/t/maint/php-tag.t
@@ -17,11 +17,11 @@
1818 for my $file (@files) {
1919 my $cont = slurp $file;
2020 if ( $cont =~ m<<\?php .* \?>>xs ) {
21 - ok 1 => "$file has <?php ?>";
 21+ pass "$file has <?php ?>";
2222 } elsif ( $cont =~ m<<\? .* \?>>xs ) {
23 - ok 0 => "$file does not use <? ?>";
 23+ fail "$file does not use <? ?>";
2424 } else {
25 - ok 1 => "$file has neither <?php ?> nor <? ?>, check it";
 25+ pass "$file has neither <?php ?> nor <? ?>, check it";
2626 }
2727 }
2828
Index: trunk/phase3/t/maint/unix-newlines.t
@@ -18,9 +18,9 @@
1919 for my $file (@files) {
2020 my $cont = slurp $file;
2121 if ( $cont and $cont =~ $CRLF ) {
22 - ok 0 => "$file contains windows newlines";
 22+ pass "$file contains windows newlines";
2323 } else {
24 - ok 1 => "$file is made of unix newlines and win";
 24+ fail "$file is made of unix newlines and win";
2525 }
2626 }
2727
Property changes on: .
___________________________________________________________________
Modified: svk:merge
2828 - 27bc04cf-33ed-4153-9a14-f265503a8842:/local/mediawiki:61199
7cf7ea9e-0fb0-4aec-bfeb-b705e7e456c6:/local/mediawiki:61660
2929 + 27bc04cf-33ed-4153-9a14-f265503a8842:/local/mediawiki:61202
7cf7ea9e-0fb0-4aec-bfeb-b705e7e456c6:/local/mediawiki:61660

Follow-up revisions

RevisionCommit summaryAuthorDate
r24215Merged revisions 24095-24212 via svnmerge from...david21:19, 17 July 2007

Status & tagging log