r24159 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24158‎ | r24159 | r24160 >
Date:11:30, 16 July 2007
Author:robchurch
Status:old
Tags:
Comment:
Less verbose; don't bother with "return not evaluated", gives the wrong impression (i.e. hooks *have* to return something) - if the return would affect whether or not an operation occurs, it's probably better to be explicit about this, e.g. "Set $result and return false to override..."
Modified paths:
  • /trunk/phase3/docs/hooks.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/hooks.txt
@@ -561,9 +561,8 @@
562562 &$sktemplate: SkinTemplate object
563563 &$tpl: Template engine object
564564
565 -'SpecialContributionsBeforeMainOutput': Before the contributions form. Return
566 -not evaluated, audit only.
567 -$id: The id of the user whose contributions are being accessed.
 565+'SpecialContributionsBeforeMainOutput': Before the form on Special:Contributions
 566+$id: User identifier
568567
569568 'TitleLinkUpdatesAfterCompletion': after Linker->doUpdate() is called
570569 &$title: title of the updated page

Follow-up revisions

RevisionCommit summaryAuthorDate
r24215Merged revisions 24095-24212 via svnmerge from...david21:19, 17 July 2007

Status & tagging log