r24098 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24097‎ | r24098 | r24099 >
Date:23:59, 14 July 2007
Author:robchurch
Status:old
Tags:
Comment:
Show the spinner for the destination filename check, too
Modified paths:
  • /trunk/phase3/skins/common/upload.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/upload.js
@@ -54,7 +54,6 @@
5555 return;
5656 }
5757
58 - this.setInnerHTML(warningElt, '..'); // TODO: pretty animated GIF
5958 this.timeoutID = window.setTimeout( 'wgUploadWarningObj.timeout()', this.delay );
6059 },
6160
@@ -67,8 +66,7 @@
6867 },
6968
7069 'timeout' : function() {
71 - var warningElt = document.getElementById( 'wpDestFile-warning' );
72 - this.setInnerHTML(warningElt, '....'); // TODO: pretty animated GIF
 70+ injectSpinner( document.getElementById( 'wpDestFile' ), 'destcheck' );
7371
7472 // Get variables into local scope so that they will be preserved for the
7573 // anonymous callback. fileName is copied so that multiple overlapping
@@ -83,6 +81,7 @@
8482 },
8583
8684 'processResult' : function (result, fileName) {
 85+ removeSpinner( 'destcheck' );
8786 this.setWarning(result.responseText);
8887 this.responseCache[fileName] = result.responseText;
8988 },

Follow-up revisions

RevisionCommit summaryAuthorDate
r24215Merged revisions 24095-24212 via svnmerge from...david21:19, 17 July 2007

Status & tagging log