r24091 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24090‎ | r24091 | r24092 >
Date:18:41, 14 July 2007
Author:robchurch
Status:old
Tags:
Comment:
(bug 10530) Introduce optional "sp-contributions-explain" message for additional explanation in Special:Contributions
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialContributions.php (modified) (history)
  • /trunk/phase3/maintenance/language/messageTypes.inc (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -1248,6 +1248,7 @@
12491249 'sp-contributions-search',
12501250 'sp-contributions-username',
12511251 'sp-contributions-submit',
 1252+ 'sp-contributions-explain',
12521253 'sp-contributions-footer',
12531254 'sp-contributions-footer-anon',
12541255 ),
Index: trunk/phase3/maintenance/language/messageTypes.inc
@@ -193,6 +193,7 @@
194194 'exif-filesource-3',
195195 'booksources-isbn',
196196 'isbn',
 197+ 'sp-contributions-explain',
197198 );
198199
199200 /** EXIF messages, which may be set as optional in several checks, but are generally mandatory */
Index: trunk/phase3/includes/SpecialContributions.php
@@ -431,8 +431,13 @@
432432 Xml::label( wfMsg( 'month' ), 'month' ) . ' '.
433433 Xml::monthSelector( $options['month'], -1 ) . ' '.
434434 Xml::submitButton( wfMsg( 'sp-contributions-submit' ) ) .
435 - Xml::closeElement( 'p' ) .
436 - '</fieldset>' .
 435+ Xml::closeElement( 'p' );
 436+
 437+ $explain = wfMsgExt( 'sp-contributions-explain', 'parseinline' );
 438+ if( !wfEmptyMsg( 'sp-contributions-explain', $explain ) )
 439+ $f .= "<p>{$explain}</p>";
 440+
 441+ $f .= '</fieldset>' .
437442 Xml::closeElement( 'form' );
438443 return $f;
439444 }
\ No newline at end of file
Index: trunk/phase3/RELEASE-NOTES
@@ -134,8 +134,9 @@
135135 * Link to user logs in toolbox when viewing a user page
136136 * (bug 10508) Allow HTML attributes on <gallery>
137137 * (bug 1962) Allow HTML attributes on <math>
 138+* (bug 10530) Introduce optional "sp-contributions-explain" message for
 139+ additional explanation in Special:Contributions
138140
139 -
140141 == Bugfixes since 1.10 ==
141142
142143 * (bug 9712) Use Arabic comma in date/time formats for Arabic and Farsi

Follow-up revisions

RevisionCommit summaryAuthorDate
r24096Merged revisions 23910-24094 via svnmerge from...david22:38, 14 July 2007

Status & tagging log