r24060 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24059‎ | r24060 | r24061 >
Date:12:06, 13 July 2007
Author:mkroetzsch
Status:old
Tags:
Comment:
Changes to account for new query parameters.
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialAsk.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialAsk.php
@@ -23,7 +23,7 @@
2424 class SMW_AskPage {
2525
2626 static function execute() {
27 - global $wgRequest, $wgOut, $smwgQEnabled, $smwgQMaxLimit, $wgUser, $smwgIQSortingEnabled;
 27+ global $wgRequest, $wgOut, $smwgQEnabled, $smwgQMaxLimit, $wgUser, $smwgQSortingSupport;
2828
2929 $skin = $wgUser->getSkin();
3030
@@ -31,7 +31,7 @@
3232 $sort = $wgRequest->getVal( 'sort' );
3333 $order = $wgRequest->getVal( 'order' );
3434 $limit = $wgRequest->getVal( 'limit' );
35 - if ('' == $limit) $limit = 20; //$smwgIQDefaultLimit;
 35+ if ('' == $limit) $limit = 20;
3636 $offset = $wgRequest->getVal( 'offset' );
3737 if ('' == $offset) $offset = 0;
3838
@@ -43,7 +43,7 @@
4444 '<input type="hidden" name="title" value="' . $spectitle->getPrefixedText() . '"/>' ;
4545 $html .= '<textarea name="query" cols="40" rows="6">' . htmlspecialchars($query) . '</textarea><br />' . "\n";
4646
47 - if ($smwgIQSortingEnabled) {
 47+ if ($smwgQSortingSupport) {
4848 $html .= wfMsg('smw_ask_sortby') . ' <input type="text" name="sort" value="' .
4949 htmlspecialchars($sort) . '"/> <select name="order"><option ';
5050 // TODO: don't show sort widgets if sorting is not enabled

Status & tagging log