r24030 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24029‎ | r24030 | r24031 >
Date:13:34, 12 July 2007
Author:mkroetzsch
Status:old
Tags:
Comment:
Check for output buffer (missing buffer messages occurred on some installations, hopefully fixed now)
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore.php
@@ -694,15 +694,6 @@
695695
696696 extract( $db->tableNames('smw_relations','smw_attributes','smw_longstrings','smw_specialprops') );
697697
698 -/// DEBUG
699 -// $this->setupTable('smw_test2',
700 -// array('subject_id' => 'INT(8) UNSIGNED NOT NULL',
701 -// 'subject_namespace' => 'INT(11) NOT NULL',
702 -// 'subject_title' => 'VARCHAR(245) NOT NULL',
703 -// //'nullvalue' => 'VARCHAR(255)',
704 -// 'value_unit2' => 'VARCHAR(64)',
705 -// 'value_unit' => 'VARCHAR(61) NOT NULL'), $db, $verbose);
706 -
707698 // create relation table
708699 $this->setupTable($smw_relations,
709700 array('subject_id' => 'INT(8) UNSIGNED NOT NULL',
@@ -1281,6 +1272,9 @@
12821273 if (!$verbose) {
12831274 return;
12841275 }
 1276+ if (ob_get_level() == 0) { // be sure to have some buffer, otherwise some PHPs complain
 1277+ ob_start();
 1278+ }
12851279 print $msg;
12861280 ob_flush();
12871281 flush();

Status & tagging log