r24021 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r24020‎ | r24021 | r24022 >
Date:20:26, 11 July 2007
Author:aaron
Status:old
Tags:
Comment:
*Still use = for LIST_SET so as not no kill non-where queries
Modified paths:
  • /trunk/phase3/includes/Database.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Database.php
@@ -1534,8 +1534,10 @@
15351535 } elseif ( ($mode == LIST_AND || $mode == LIST_OR) && is_array($value) ) {
15361536 $list .= $field." IN (".$this->makeList($value).") ";
15371537 } elseif( is_null($value) ) {
1538 - if ( $mode == LIST_AND || $mode == LIST_OR || $mode == LIST_SET ) {
 1538+ if ( $mode == LIST_AND || $mode == LIST_OR ) {
15391539 $list .= "$field IS ";
 1540+ } elseif ( $mode == LIST_SET ) {
 1541+ $list .= "$field = ";
15401542 }
15411543 $list .= 'NULL';
15421544 } else {

Follow-up revisions

RevisionCommit summaryAuthorDate
r24096Merged revisions 23910-24094 via svnmerge from...david22:38, 14 July 2007

Status & tagging log