r23996 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23995‎ | r23996 | r23997 >
Date:08:43, 11 July 2007
Author:nickj
Status:old
Tags:
Comment:
(bug 10332) Title->userCan( 'edit' ) may return false positive
(If this is not convenient for the userCan refactoring, then please revert this and reopen the bug)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -1103,6 +1103,11 @@
11041104 }
11051105 }
11061106
 1107+ if( $action == 'edit' && !$wgUser->isAllowed( 'edit' ) ) {
 1108+ wfProfileOut( $fname );
 1109+ return false;
 1110+ }
 1111+
11071112 wfProfileOut( $fname );
11081113 return true;
11091114 }
Index: trunk/phase3/RELEASE-NOTES
@@ -276,6 +276,7 @@
277277 * (bug 9903) Don't mark redirects in categories as stubs
278278 * (bug 6965) Cannot include "Template:R" with {{R}} (magic word conflict)
279279 * Padding parser functions now work with strings like '0' that evaluate to false
 280+* (bug 10332) Title->userCan( 'edit' ) may return false positive
280281
281282 == API changes since 1.10 ==
282283

Follow-up revisions

RevisionCommit summaryAuthorDate
r24096Merged revisions 23910-24094 via svnmerge from...david22:38, 14 July 2007

Status & tagging log