r23973 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23972‎ | r23973 | r23974 >
Date:19:37, 10 July 2007
Author:brion
Status:old
Tags:
Comment:
Fix regression caused by the namespace check on oldid override.
Don't die if we don't have a valid title yet!
Modified paths:
  • /trunk/phase3/includes/Wiki.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Wiki.php
@@ -102,7 +102,8 @@
103103 $lang->findVariantLink( $title, $ret );
104104
105105 }
106 - if ( $ret->getNamespace() != NS_SPECIAL && $oldid = $request->getInt( 'oldid' ) ) {
 106+ if ( $oldid = $request->getInt( 'oldid' )
 107+ && ( is_null( $ret ) || $ret->getNamespace() != NS_SPECIAL ) ) {
107108 // Allow oldid to override a changed or missing title.
108109 $rev = Revision::newFromId( $oldid );
109110 if( $rev ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r24096Merged revisions 23910-24094 via svnmerge from...david22:38, 14 July 2007

Status & tagging log