r23966 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23965‎ | r23966 | r23967 >
Date:15:02, 10 July 2007
Author:mkroetzsch
Status:old
Tags:
Comment:
Fixed interplay of disjunctions and (hierarchy-resolving) category queries
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore.php
@@ -1051,7 +1051,8 @@
10521052 global $smwgIQSubcategoryInclusions;
10531053 if ($smwgIQSubcategoryInclusions > 0) {
10541054 $ct = $this->getCategoryTable($description->getCategory()->getDBKey(), $db);
1055 - $from .= " INNER JOIN $ct ON $ct.cat_name=" . $curtables['CATS'] . '.cl_to';
 1055+ $from = '`' . $ct . '`, ' . $from;
 1056+ $where = "$ct.cat_name=" . $curtables['CATS'] . '.cl_to';
10561057 } else {
10571058 $where .= $curtables['CATS'] . '.cl_to=' . $db->addQuotes($description->getCategory()->getDBKey());
10581059 }

Status & tagging log