r23961 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23960‎ | r23961 | r23962 >
Date:14:47, 10 July 2007
Author:mkroetzsch
Status:old
Tags:
Comment:
-bug: use of prefixed table name in db->select
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore.php
@@ -628,7 +628,7 @@
629629 $result .= '<br /><b>Auxilliary tables used (possibly in multiple copies)</b><br />';
630630 foreach (SMWSQLStore::$m_categorytables as $tablename) {
631631 $result .= $tablename . ': ';
632 - $res = $db->select( $tablename, 'cat_name', '', 'SMW::getQueryResult:DEBUG');
 632+ $res = $db->query( "SELECT cat_name FROM $tablename", 'SMW::getQueryResult:DEBUG');
633633 while ( $row = $db->fetchObject($res) ) {
634634 $result .= $row->cat_name . ', ';
635635 }

Status & tagging log