r23952 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23951‎ | r23952 | r23953 >
Date:12:25, 10 July 2007
Author:robchurch
Status:old
Tags:
Comment:
* (bug 9903) Don't mark redirects in categories as stubs [wrong semantics]
* Escaping issue
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/CategoryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/CategoryPage.php
@@ -165,12 +165,9 @@
166166 */
167167 function addPage( $title, $sortkey, $pageLength, $isRedirect = false ) {
168168 global $wgContLang;
169 - $link = $this->getSkin()->makeSizeLinkObj(
170 - $pageLength, $title, $wgContLang->convert( $title->getPrefixedText() )
171 - );
172 - if ($isRedirect)
173 - $link = '<span class="redirect-in-category">'.$link.'</span>';
174 - $this->articles[] = $link;
 169+ $this->articles[] = $isRedirect
 170+ ? '<span class="redirect-in-category">' . $this->getSkin()->makeKnownLinkObj( $title ) . '</span>'
 171+ : $this->getSkin()->makeSizeLinkObj( $pageLength, $title );
175172 $this->articles_start_char[] = $wgContLang->convert( $wgContLang->firstChar( $sortkey ) );
176173 }
177174
Index: trunk/phase3/RELEASE-NOTES
@@ -268,6 +268,7 @@
269269 * (bug 10495) $wgMemcachedDebug set twice in includes/DefaultSettings.php
270270 * (bug 10316) Prevent inconsistent cached skin settings in gen=js by setting
271271 the intended skin directly in the URL.
 272+* (bug 9903) Don't mark redirects in categories as stubs
272273
273274
274275 == API changes since 1.10 ==

Follow-up revisions

RevisionCommit summaryAuthorDate
r24096Merged revisions 23910-24094 via svnmerge from...david22:38, 14 July 2007
r80590Follow up r80432. Don't use 'known', 'noclasses' when making the links on cat...bawolff21:51, 19 January 2011

Status & tagging log