r23944 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23943‎ | r23944 | r23945 >
Date:09:36, 10 July 2007
Author:proes
Status:old
Tags:
Comment:
* Also support property to column filtering on edit and history page
* Properly escape URLs for valid HTML
Modified paths:
  • /trunk/extensions/Wikidata/OmegaWiki/Wikidata.php (modified) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/type.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikidata/OmegaWiki/Wikidata.php
@@ -129,6 +129,7 @@
130130 $viewInformation->filterLanguageId = $this->filterLanguageId;
131131 $viewInformation->possiblySynonymousRelationTypeId = $this->possiblySynonymousRelationTypeId;
132132 $viewInformation->queryTransactionInformation = $referenceQueryTransactionInformation;
 133+ $viewInformation->setPropertyToColumnFilters($this->propertyToColumnFilters);
133134 $viewInformation->viewOrEdit = "edit";
134135
135136 $this->viewInformation = $viewInformation;
@@ -185,6 +186,7 @@
186187 $viewInformation->showRecordLifeSpan = false;
187188 $viewInformation->queryTransactionInformation = new QueryLatestTransactionInformation();
188189 $viewInformation->viewOrEdit = "edit";
 190+ $viewInformation->setPropertyToColumnFilters($this->propertyToColumnFilters);
189191
190192 $this->viewInformation = $viewInformation;
191193
@@ -241,6 +243,7 @@
242244 $viewInformation->possiblySynonymousRelationTypeId = $this->possiblySynonymousRelationTypeId;
243245 $viewInformation->showRecordLifeSpan = $this->showRecordLifeSpan;
244246 $viewInformation->queryTransactionInformation = $this->queryTransactionInformation;
 247+ $viewInformation->setPropertyToColumnFilters($this->propertyToColumnFilters);
245248
246249 $this->viewInformation = $viewInformation;
247250
Index: trunk/extensions/Wikidata/OmegaWiki/type.php
@@ -48,8 +48,7 @@
4949 }
5050
5151 function createLink($url, $text) {
52 -
53 - return '<a href="'. $url . '">' . htmlspecialchars($text) . '</a>';
 52+ return '<a href="'. htmlspecialchars($url) . '">' . htmlspecialchars($text) . '</a>';
5453 }
5554
5655 function spellingAsLink($spelling) {

Status & tagging log