r23894 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23893‎ | r23894 | r23895 >
Date:10:28, 9 July 2007
Author:mkroetzsch
Status:old
Tags:
Comment:
Move all images to ./skins/images
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/skins/SMW_custom.css (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/SMW_sorttable.js (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/browse_icon.png (deleted) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/browse_iconsmall.png (deleted) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/images/browse_icon.png (added) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/images/browse_icon.png (added) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/images/browse_iconsmall.png (added) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/images/browse_iconsmall.png (added) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/images/rdf_flyer.18.gif (added) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/images/rdf_flyer.18.gif (added) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/images/search_icon.png (added) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/images/search_icon.png (added) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/images/searchgray_iconsmall.png (added) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/images/searchgray_iconsmall.png (added) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/images/sort_down.gif (added) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/images/sort_down.gif (added) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/images/sort_none.gif (added) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/images/sort_none.gif (added) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/images/sort_up.gif (added) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/images/sort_up.gif (added) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/images/world.png (added) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/images/world.png (added) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/rdf_flyer.18.gif (deleted) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/rdf_flyer.20.gif (deleted) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/search_icon.png (deleted) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/search_iconsmall.png (deleted) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/searchgray_icon.png (deleted) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/searchgray_iconsmall.png (deleted) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/sort_down.gif (deleted) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/sort_none.gif (deleted) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/sort_up.gif (deleted) (history)
  • /trunk/extensions/SemanticMediaWiki/skins/world.png (deleted) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/skins/search_iconsmall.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/SemanticMediaWiki/skins/browse_icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/SemanticMediaWiki/skins/sort_up.gif
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/SemanticMediaWiki/skins/rdf_flyer.20.gif
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/SemanticMediaWiki/skins/search_icon.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/SemanticMediaWiki/skins/rdf_flyer.18.gif
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/SemanticMediaWiki/skins/sort_none.gif
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/SemanticMediaWiki/skins/world.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/SemanticMediaWiki/skins/searchgray_iconsmall.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/SemanticMediaWiki/skins/sort_down.gif
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/SemanticMediaWiki/skins/searchgray_icon.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/SemanticMediaWiki/skins/browse_iconsmall.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/SemanticMediaWiki/skins/images/searchgray_iconsmall.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/SemanticMediaWiki/skins/images/searchgray_iconsmall.png
___________________________________________________________________
Added: svn:mime-type
11 + application/octet-stream
Index: trunk/extensions/SemanticMediaWiki/skins/images/sort_down.gif
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/SemanticMediaWiki/skins/images/sort_down.gif
___________________________________________________________________
Added: svn:mime-type
22 + application/octet-stream
Index: trunk/extensions/SemanticMediaWiki/skins/images/browse_iconsmall.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/SemanticMediaWiki/skins/images/browse_iconsmall.png
___________________________________________________________________
Added: svn:mime-type
33 + image/png
Index: trunk/extensions/SemanticMediaWiki/skins/images/rdf_flyer.18.gif
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/SemanticMediaWiki/skins/images/rdf_flyer.18.gif
___________________________________________________________________
Added: svn:mime-type
44 + application/octet-stream
Index: trunk/extensions/SemanticMediaWiki/skins/images/world.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/SemanticMediaWiki/skins/images/world.png
___________________________________________________________________
Added: svn:mime-type
55 + application/octet-stream
Index: trunk/extensions/SemanticMediaWiki/skins/images/sort_none.gif
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/SemanticMediaWiki/skins/images/sort_none.gif
___________________________________________________________________
Added: svn:mime-type
66 + application/octet-stream
Index: trunk/extensions/SemanticMediaWiki/skins/images/browse_icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/SemanticMediaWiki/skins/images/browse_icon.png
___________________________________________________________________
Added: svn:mime-type
77 + image/png
Index: trunk/extensions/SemanticMediaWiki/skins/images/sort_up.gif
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/SemanticMediaWiki/skins/images/sort_up.gif
___________________________________________________________________
Added: svn:mime-type
88 + application/octet-stream
Index: trunk/extensions/SemanticMediaWiki/skins/images/search_icon.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/SemanticMediaWiki/skins/images/search_icon.png
___________________________________________________________________
Added: svn:mime-type
99 + application/octet-stream
Index: trunk/extensions/SemanticMediaWiki/skins/SMW_custom.css
@@ -133,14 +133,14 @@
134134 padding-right: 16px;
135135 margin-right: 2px;
136136 color: #888888;
137 - background: url(searchgray_iconsmall.png) center right no-repeat;
 137+ background: url(images/searchgray_iconsmall.png) center right no-repeat;
138138 }
139139
140140 #bodyContent span.smwsearch a{
141141 padding-right: 16px;
142142 margin-right: 2px;
143143 color: #888888;
144 - background: url(searchgray_iconsmall.png) center right no-repeat;
 144+ background: url(images/searchgray_iconsmall.png) center right no-repeat;
145145 }
146146
147147 #bodyContent span.smwsearch a:hover{
@@ -148,21 +148,21 @@
149149 color: #0000FF;
150150 padding-right: 18px;
151151 margin-right: 0px;
152 - background: url(search_icon.png) center right no-repeat;
 152+ background: url(images/search_icon.png) center right no-repeat;
153153 }
154154
155155 span.smwbrowseicon {
156156 padding-right: 16px;
157157 margin-right: 2px;
158158 color: #888888;
159 - background: url(browse_iconsmall.png) center right no-repeat;
 159+ background: url(images/browse_iconsmall.png) center right no-repeat;
160160 }
161161
162162 #bodyContent span.swmfactboxheadbrowse a{
163163 padding-right: 16px;
164164 margin-right: 2px;
165165 color: #000000;
166 - background: url(browse_iconsmall.png) center right no-repeat;
 166+ background: url(images/browse_iconsmall.png) center right no-repeat;
167167 }
168168
169169 #bodyContent span.swmfactboxheadbrowse a:hover{
@@ -170,14 +170,14 @@
171171 color: #0000FF;
172172 padding-right: 18px;
173173 margin-right: 0px;
174 - background: url(browse_icon.png) center right no-repeat;
 174+ background: url(images/browse_icon.png) center right no-repeat;
175175 }
176176
177177 #bodyContent span.smwbrowse a{
178178 padding-right: 16px;
179179 margin-right: 2px;
180180 color: #888888;
181 - background: url(browse_iconsmall.png) center right no-repeat;
 181+ background: url(images/browse_iconsmall.png) center right no-repeat;
182182 }
183183
184184 #bodyContent span.smwbrowse a:hover{
@@ -185,7 +185,7 @@
186186 color: #0000FF;
187187 padding-right: 18px;
188188 margin-right: 0px;
189 - background: url(browse_icon.png) center right no-repeat;
 189+ background: url(images/browse_icon.png) center right no-repeat;
190190 }
191191
192192 /* Do not gray browse link in factbox header */
@@ -193,7 +193,7 @@
194194 padding-right: 16px;
195195 margin-right: 2px;
196196 color: black;
197 - background: url(browse_iconsmall.png) center right no-repeat;
 197+ background: url(images/browse_iconsmall.png) center right no-repeat;
198198 }
199199
200200 /* Do not gray browse link in factbox header */
@@ -202,19 +202,19 @@
203203 color: #0000FF;
204204 padding-right: 18px;
205205 margin-right: 0px;
206 - background: url(browse_icon.png) center right no-repeat;
 206+ background: url(images/browse_icon.png) center right no-repeat;
207207 }
208208
209209 #bodyContent span.smwmap a{
210210 padding-right: 20px;
211211 color: #888888;
212 - background: url(world.png) center right no-repeat;
 212+ background: url(images/world.png) center right no-repeat;
213213 }
214214
215215 #bodyContent span.smwmap a:hover{
216216 padding-right: 20px;
217217 color: #0000FF;
218 - background: url(world.png) center right no-repeat;
 218+ background: url(images/world.png) center right no-repeat;
219219 }
220220
221221 /* RDF icons */
@@ -226,7 +226,7 @@
227227 #bodyContent span.rdflink a{
228228 padding-right: 20px;
229229 color: #888888;
230 - background: url(rdf_flyer.18.gif) center right no-repeat;
 230+ background: url(images/rdf_flyer.18.gif) center right no-repeat;
231231
232232 }
233233
@@ -235,7 +235,7 @@
236236 color: #0000FF;
237237 padding-right: 20px;
238238 margin-right: 0px;
239 - background: url(rdf_flyer.18.gif) center right no-repeat;
 239+ background: url(images/rdf_flyer.18.gif) center right no-repeat;
240240 }
241241
242242 /* tooltips */
Index: trunk/extensions/SemanticMediaWiki/skins/SMW_sorttable.js
@@ -36,11 +36,11 @@
3737 // preload icons needed by SMW
3838 if (document.images) {
3939 pic1= new Image(12,14);
40 - pic1.src = SMW_PATH + "/sort_up.gif";
 40+ pic1.src = SMW_PATH + "/images/sort_up.gif";
4141 pic2= new Image(12,14);
42 - pic2.src = SMW_PATH + "/sort_down.gif";
 42+ pic2.src = SMW_PATH + "/images/sort_down.gif";
4343 pic3= new Image(16,16);
44 - pic3.src = SMW_PATH + "/search_icon.png";
 44+ pic3.src = SMW_PATH + "/images/search_icon.png"; // TODO: move this preload to somewhere else?
4545 }
4646 }
4747
@@ -57,7 +57,7 @@
5858 //var txt = smw_getInnerText(cell); // unused -- we preserve the inner html
5959 cell.innerHTML = '<a href="#" class="sortheader" '+
6060 'onclick="smw_resortTable(this, '+i+');return false;">' +
61 - '<span class="sortarrow"><img alt="[&lt;&gt;]" src="' + SMW_PATH + '/sort_none.gif"/></span></a>&nbsp;<span style="margin-left: 0.3em; margin-right: 1em;">' + cell.innerHTML + '</span>'; // the &nbsp; is for Opera ...
 61+ '<span class="sortarrow"><img alt="[&lt;&gt;]" src="' + SMW_PATH + '/images/sort_none.gif"/></span></a>&nbsp;<span style="margin-left: 0.3em; margin-right: 1em;">' + cell.innerHTML + '</span>'; // the &nbsp; is for Opera ...
6262 }
6363 }
6464
@@ -99,7 +99,7 @@
100100 sortfn = smw_sort_caseinsensitive;
101101 if (itm.match(/^\d\d[\/-]\d\d[\/-]\d\d\d\d$/)) sortfn = smw_sort_date;
102102 if (itm.match(/^\d\d[\/-]\d\d[\/-]\d\d$/)) sortfn = smw_sort_date;
103 - if (itm.match(/^[�$]/)) sortfn = smw_sort_currency;
 103+ if (itm.match(/^[�$]/)) sortfn = smw_sort_currency;
104104 if (itm.match(/^[\d\.]+$/)) sortfn = smw_sort_numeric;
105105 SORT_COLUMN_INDEX = column;
106106 var firstRow = new Array();
@@ -116,11 +116,11 @@
117117
118118 var ARROW;
119119 if (span.getAttribute("sortdir") == 'down') {
120 - ARROW = '<img alt="[&gt;]" src="' + SMW_PATH + '/sort_up.gif"/>';
 120+ ARROW = '<img alt="[&gt;]" src="' + SMW_PATH + '/images/sort_up.gif"/>';
121121 newRows.reverse();
122122 span.setAttribute('sortdir','up');
123123 } else {
124 - ARROW = '<img alt="[&lt;]" src="' + SMW_PATH + '/sort_down.gif"/>';
 124+ ARROW = '<img alt="[&lt;]" src="' + SMW_PATH + '/images/sort_down.gif"/>';
125125 span.setAttribute('sortdir','down');
126126 }
127127
@@ -136,7 +136,7 @@
137137 for (var ci=0;ci<allspans.length;ci++) {
138138 if (allspans[ci].className == 'sortarrow') {
139139 if (smw_getParent(allspans[ci],"table") == smw_getParent(lnk,"table")) { // in the same table as us?
140 - allspans[ci].innerHTML = '<img alt="[&lt;&gt;]" src="' + SMW_PATH + '/sort_none.gif"/>';
 140+ allspans[ci].innerHTML = '<img alt="[&lt;&gt;]" src="' + SMW_PATH + '/images/sort_none.gif"/>';
141141 }
142142 }
143143 }

Status & tagging log