r23884 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23883‎ | r23884 | r23885 >
Date:05:19, 9 July 2007
Author:yurik
Status:old
Tags:
Comment:
API: fixed timestamp format for 'continue' values
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryLogEvents.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryRecentChanges.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryUserContributions.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryWatchlist.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryRecentChanges.php
@@ -110,7 +110,7 @@
111111 while ($row = $db->fetchObject($res)) {
112112 if (++ $count > $limit) {
113113 // We've reached the one extra which shows that there are additional pages to be had. Stop here...
114 - $this->setContinueEnumParameter('start', $row->rc_timestamp);
 114+ $this->setContinueEnumParameter('start', wfTimestamp(TS_ISO_8601, $row->rc_timestamp));
115115 break;
116116 }
117117
Index: trunk/phase3/includes/api/ApiQueryWatchlist.php
@@ -148,7 +148,7 @@
149149 while ($row = $db->fetchObject($res)) {
150150 if (++ $count > $limit) {
151151 // We've reached the one extra which shows that there are additional pages to be had. Stop here...
152 - $this->setContinueEnumParameter('start', $row->rc_timestamp);
 152+ $this->setContinueEnumParameter('start', wfTimestamp(TS_ISO_8601, $row->rc_timestamp));
153153 break;
154154 }
155155
Index: trunk/phase3/includes/api/ApiQueryUserContributions.php
@@ -75,7 +75,7 @@
7676 while ( $row = $db->fetchObject( $res ) ) {
7777 if (++ $count > $limit) {
7878 // We've reached the one extra which shows that there are additional pages to be had. Stop here...
79 - $this->setContinueEnumParameter('start', $row->rev_timestamp);
 79+ $this->setContinueEnumParameter('start', wfTimestamp(TS_ISO_8601, $row->rev_timestamp));
8080 break;
8181 }
8282
Index: trunk/phase3/includes/api/ApiQueryLogEvents.php
@@ -93,7 +93,7 @@
9494 while ($row = $db->fetchObject($res)) {
9595 if (++ $count > $limit) {
9696 // We've reached the one extra which shows that there are additional pages to be had. Stop here...
97 - $this->setContinueEnumParameter('start', $row->log_timestamp);
 97+ $this->setContinueEnumParameter('start', wfTimestamp(TS_ISO_8601, $row->log_timestamp));
9898 break;
9999 }
100100

Follow-up revisions

RevisionCommit summaryAuthorDate
r23912Merged revisions 23662-23909 via svnmerge from...david18:11, 9 July 2007

Status & tagging log