r23827 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23826‎ | r23827 | r23828 >
Date:04:58, 7 July 2007
Author:yurik
Status:old
Tags:
Comment:
API: slightly better naming for db repl lag
Modified paths:
  • /trunk/phase3/includes/api/ApiQuerySiteinfo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQuerySiteinfo.php
@@ -57,8 +57,8 @@
5858 $filteriw = isset($params['filteriw']) ? $params['filteriw'] : false;
5959 $this->appendInterwikiMap($p, $filteriw);
6060 break;
61 - case 'dbserverlag' :
62 - $this->appendDbServerLagInfo($p, $params['showalldb']);
 61+ case 'dbrepllag' :
 62+ $this->appendDbReplLagInfo($p, $params['showalldb']);
6363 break;
6464 }
6565 }
@@ -131,7 +131,7 @@
132132 $this->getResult()->addValue('query', $property, $data);
133133 }
134134
135 - protected function appendDbServerLagInfo($property, $includeAll) {
 135+ protected function appendDbReplLagInfo($property, $includeAll) {
136136 global $wgLoadBalancer;
137137
138138 $data = array();
@@ -166,7 +166,7 @@
167167 'general',
168168 'namespaces',
169169 'interwikimap',
170 - 'dbserverlag',
 170+ 'dbrepllag',
171171 )),
172172
173173 'filteriw' => array (
@@ -186,7 +186,7 @@
187187 ' "general" - Overall system information',
188188 ' "namespaces" - List of registered namespaces (localized)',
189189 ' "interwikimap" - Return interwiki map (optionally filtered)',
190 - ' "dbserverlag" - Get highest database replication server lag',
 190+ ' "dbrepllag" - Returns DB server with the highest replication lag',
191191 ),
192192 'filteriw' => 'Return only local or only nonlocal entries of the interwiki map',
193193 'showalldb' => 'List all DB servers, not just the one lagging the most',
@@ -201,6 +201,7 @@
202202 return array(
203203 'api.php?action=query&meta=siteinfo&siprop=general|namespaces',
204204 'api.php?action=query&meta=siteinfo&siprop=interwikimap&sifilteriw=local',
 205+ 'api.php?action=query&meta=siteinfo&siprop=dbrepllag&sishowalldb',
205206 );
206207 }
207208

Follow-up revisions

RevisionCommit summaryAuthorDate
r23912Merged revisions 23662-23909 via svnmerge from...david18:11, 9 July 2007

Status & tagging log