r23796 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23795‎ | r23796 | r23797 >
Date:19:20, 6 July 2007
Author:aaron
Status:old
Tags:
Comment:
*Typo
Modified paths:
  • /trunk/phase3/includes/Pager.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Pager.php
@@ -170,14 +170,14 @@
171171 * @param boolean $descending Query direction, false for ascending, true for descending
172172 * @return ResultWrapper
173173 */
174 - function reallyDoQuery( $offset, $limit, $ascending ) {
 174+ function reallyDoQuery( $offset, $limit, $descending ) {
175175 $fname = __METHOD__ . ' (' . get_class( $this ) . ')';
176176 $info = $this->getQueryInfo();
177177 $tables = $info['tables'];
178178 $fields = $info['fields'];
179179 $conds = isset( $info['conds'] ) ? $info['conds'] : array();
180180 $options = isset( $info['options'] ) ? $info['options'] : array();
181 - if ( $ascending ) {
 181+ if ( $descending ) {
182182 $options['ORDER BY'] = $this->mIndexField;
183183 $operator = '>';
184184 } else {

Follow-up revisions

RevisionCommit summaryAuthorDate
r23912Merged revisions 23662-23909 via svnmerge from...david18:11, 9 July 2007

Status & tagging log