| Index: trunk/phase3/includes/Skin.php |
| — | — | @@ -412,12 +412,17 @@ |
| 413 | 413 | } |
| 414 | 414 | |
| 415 | 415 | /** |
| 416 | | - * This returns MediaWiki:Common.js. For some bizarre reason, it does |
| 417 | | - * *not* return any custom user JS from user subpages. Huh? |
| | 416 | + * This returns MediaWiki:Common.js, and derived classes may add other JS. |
| | 417 | + * Despite its name, it does *not* return any custom user JS from user |
| | 418 | + * subpages. The returned script is sitewide and publicly cacheable and |
| | 419 | + * therefore must not include anything that varies according to user, |
| | 420 | + * interface language, etc. (although it may vary by skin). See |
| | 421 | + * makeGlobalVariablesScript for things that can vary per page view and are |
| | 422 | + * not cacheable. |
| 418 | 423 | * |
| 419 | | - * @return string |
| | 424 | + * @return string Raw JavaScript to be returned |
| 420 | 425 | */ |
| 421 | | - function getUserJs() { |
| | 426 | + public function getUserJs() { |
| 422 | 427 | wfProfileIn( __METHOD__ ); |
| 423 | 428 | |
| 424 | 429 | global $wgStylePath; |