r23700 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23699‎ | r23700 | r23701 >
Date:11:03, 4 July 2007
Author:catrope
Status:old
Tags:
Comment:
apiedit:
* Introducing CHANGED file that tracks changes relative to trunk
* API: Adding FIXME comment to ApiQueryRevisions.php
Modified paths:
  • /branches/apiedit/phase3/CHANGED (added) (history)
  • /branches/apiedit/phase3/includes/api/ApiQueryRevisions.php (modified) (history)

Diff [purge]

Index: branches/apiedit/phase3/CHANGED
@@ -0,0 +1,46 @@
 2+This file lists all changes in the apiedit branch relative to the trunk.
 3+Please add to this file when making a change worth mentioning
 4+It serves merely as a reference and should NOT be merged with the trunk.
 5+All paths are relative to branches/apiedit/phase3/includes/
 6+
 7+Article.php
 8+* Separated UI and DB code in Article::rollback() (r23562)
 9+** doRollback() does the dirty work, rollback() wraps around it
 10+** Introduced Article::ROLLBACK_* constants for rollback()'s return values (r23627)
 11+* Made a separate function (Article::generateReason()) for generating deletion reasons (r23590)
 12+* Added begin() and commit() to Article::doDeleteArticle() (r23590)
 13+
 14+SpecialUndelete.php
 15+* Added begin() and commit() to PageArchive::undelete() (r23687)
 16+* Changed PageArchive::undelete() to return useful information (r23697)
 17+** Introduced UNDELETE_* class constants
 18+** undelete() returns array with number of restored revisions/file versions and undeletion summary on success, UNDELETE_* on failure
 19+** Updated SpecialUndelete::undelete() to recognize changed PageArchive::undelete() return values
 20+
 21+api/ApiQueryInfo.php
 22+* Implemented tokens (r23562, r23568,r23638, r23668)
 23+* Added lastrevby field (r23562)
 24+
 25+api/ApiQueryRevisions.php
 26+* Adding lastid field (UNSTABLE, FIXME) (r23585, r23590)
 27+
 28+api/ApiRollback.php (NEW)
 29+* action=rollback module that wraps around Article::doRollback() (r23562)
 30+
 31+api/ApiDelete.php (NEW)
 32+* action=delete module that wraps around Article::doDeleteArticle() (r23590)
 33+
 34+api/ApiQueryDeletedRevs.php (NEW)
 35+* action=query&list=deletedrevs module that lists deleted revisions from the archive table (r23668)
 36+
 37+api/ApiUndelete.php (NEW)
 38+* action=undelete module that wraps around PageArchive::undelete() (r23687, r23697)
 39+
 40+AutoLoader.php
 41+* Added entries for ApiRollback (r23562), ApiDelete (r23590), ApiQueryDeletedRevs (r23668), ApiUndelete (r23687)
 42+
 43+api/ApiMain.php
 44+* Added entries for ApiRollback (r23562), ApiDelete (r23590), ApiUndelete (r23687)
 45+
 46+api/ApiQuery.php
 47+* Added entry for ApiQueryDeletedRevs (r23668)
\ No newline at end of file
Index: branches/apiedit/phase3/includes/api/ApiQueryRevisions.php
@@ -186,6 +186,7 @@
187187 $rowArr = $this->extractRowInfo($row);
188188
189189 if($this->fld_lastid) {
 190+ // Queries in loops are EVIL, FIXME
190191 $this->resetQueryParams();
191192 $this->addTables('revision');
192193 $this->addFields('rev_id');

Status & tagging log