r23682 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r23681‎ | r23682 | r23683 >
Date:19:20, 3 July 2007
Author:brion
Status:old
Tags:
Comment:
Give up on the 'consistent data set' for 'latest' symlinks.
Always use the latest individual successful file, matching the behavior of the RSS feeds.
This should also help keep from leaving bogus links when there are some partial failures leaving the old linked files expired.
Modified paths:
  • /trunk/backup/worker.py (modified) (history)

Diff [purge]

Index: trunk/backup/worker.py
——@@ -261,6 +261,7 @@
262262 self.lastFailed = True
263263 else:
264264 for f in item.listFiles(self):
 265+ self.saveSymlink(f)
265266 self.saveFeed(f)
266267 self.checksum(f)
267268 self.lastFailed = False
——@@ -477,12 +478,12 @@
478479 output.write(checksum)
479480
480481 def completeDump(self, files):
481 - self.makeDir(join(self.wiki.publicDir(), 'latest'))
482 - for file in files:
483 - self.saveSymlink(file)
 482+ # FIXME: md5sums.txt won't be consistent with mixed data.
 483+ # Buuuuut life sucks, huh?
484484 self.saveSymlink("md5sums.txt")
485485
486486 def saveSymlink(self, file):
 487+ self.makeDir(join(self.wiki.publicDir(), 'latest'))
487488 real = self.publicPath(file)
488489 link = self.latestPath(file)
489490 if exists(link) or os.path.islink(link):

Status & tagging log