r23643 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23642‎ | r23643 | r23644 >
Date:14:48, 2 July 2007
Author:proes
Status:old
Tags:
Comment:
* Solved bug: typo in DefinedMeaning.php
* Disable client cache for edit and history page to prevent out of date pages (that cause difficult to trace problems)
Modified paths:
  • /trunk/extensions/Wikidata/OmegaWiki/DefinedMeaning.php (modified) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/OmegaWiki.php (modified) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/Wikidata.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikidata/OmegaWiki/Wikidata.php
@@ -151,6 +151,8 @@
152152 global
153153 $wgOut, $wgRequest, $wgUser;
154154
 155+ $wgOut->enableClientCache(false);
 156+
155157 $dc=wdGetDataSetContext();
156158 if(!$wgUser->isAllowed('editwikidata-'.$dc)) {
157159 $wgOut->addWikiText(wfMsg('ow_noedit',$dc->fetchName()));
@@ -173,6 +175,7 @@
174176 global
175177 $wgOut, $wgTitle, $wgRequest;
176178
 179+ $wgOut->enableClientCache(false);
177180
178181 $title = $wgTitle->getPrefixedText();
179182
@@ -272,7 +275,6 @@
273276 * @return prefix (without underscore)
274277 **/
275278 function wdGetDataSetContext($dc=null) {
276 -
277279 if (!is_null($dc))
278280 return $dc;
279281 global $wgRequest, $wdDefaultViewDataSet, $wdGroupDefaultView, $wgUser;
Index: trunk/extensions/Wikidata/OmegaWiki/OmegaWiki.php
@@ -48,7 +48,6 @@
4949
5050 parent::history();
5151
52 -
5352 $spelling = $wgTitle->getText();
5453
5554 $wgOut->addHTML(
Index: trunk/extensions/Wikidata/OmegaWiki/DefinedMeaning.php
@@ -178,7 +178,7 @@
179179 */
180180 protected function getConceptPanel() {
181181 global $wgTitle, $wgUser;
182 - $active=True; # wrong place, but hey
 182+ $active=true; # wrong place, but hey
183183 $dm=$this->getDefinedMeaningId();
184184 $dc=wdGetDataSetContext();
185185 $ow_conceptpanel="Concept Panel";

Status & tagging log