r23603 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23602‎ | r23603 | r23604 >
Date:13:38, 1 July 2007
Author:magnusmanske
Status:old
Tags:
Comment:
making better use of DOM
Modified paths:
  • /trunk/phase3/skins/common/wikibits.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/wikibits.js
@@ -793,8 +793,12 @@
794794
795795 // Set warning
796796 var thetd = destFile.parentNode ;
797 -// thetd.innerHTML += url ;
798 - thetd.innerHTML += "<span id='existsWarning' style='color:red'> A file with this name already exists; uploading under the same name will replace it!</span>" ;
 797+ var nn = document.createElement("span") ;
 798+ nn.id = "existsWarning" ;
 799+ nn.style.color = "red" ;
 800+ var nt = document.createTextNode(" A file with this name already exists; uploading under the same name will replace it!");
 801+ nn.appendChild ( nt ) ;
 802+ thetd.appendChild ( nn ) ;
799803
800804 // Restore the filename
801805 var destFile = document.getElementById('wpDestFile');

Follow-up revisions

RevisionCommit summaryAuthorDate
r23662Merged revisions 23581-23661 via svnmerge from...david03:01, 3 July 2007

Status & tagging log