r23557 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23556‎ | r23557 | r23558 >
Date:14:42, 29 June 2007
Author:brion
Status:old
Tags:
Comment:
* Fix empty message checks for message names containing &
This corrects some odd behavior with sidebar items and custom namespaces
containing ampersands.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -1731,7 +1731,7 @@
17321732 * @return bool
17331733 */
17341734 function wfEmptyMsg( $msg, $wfMsgOut ) {
1735 - return $wfMsgOut === "<$msg>";
 1735+ return $wfMsgOut === htmlspecialchars( "<$msg>" );
17361736 }
17371737
17381738 /**
Index: trunk/phase3/RELEASE-NOTES
@@ -243,6 +243,9 @@
244244 * Don't use garbled parser cache output when viewing custom CSS or JavaScript
245245 pages
246246 * (bug 10406) Fix Special:Listusers filter form for non-ASCII localizations
 247+* Fix empty message checks for message names containing &
 248+ This corrects some odd behavior with sidebar items and custom namespaces
 249+ containing ampersands.
247250
248251
249252 == API changes since 1.10 ==

Follow-up revisions

RevisionCommit summaryAuthorDate
r23581Merged revisions 23406-23580 via svnmerge from...david04:50, 30 June 2007

Status & tagging log