r23511 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23510‎ | r23511 | r23512 >
Date:16:21, 28 June 2007
Author:brion
Status:old
Tags:
Comment:
* Delay AJAX watch initialization until click so IE 6 with ugly security
settings doesn't prompt you until you use the link.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/common/ajaxwatch.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/ajaxwatch.js
@@ -52,6 +52,14 @@
5353 } else if (wgAjaxWatch.inprogress) {
5454 return false;
5555 }
 56+ if(!wfSupportsAjax()) {
 57+ // Lazy initialization so we don't toss up
 58+ // ActiveX warnings on initial page load
 59+ // for IE 6 users with security settings.
 60+ wgAjaxWatch.supported = false;
 61+ return true;
 62+ }
 63+
5664 wgAjaxWatch.inprogress = true;
5765 wgAjaxWatch.setLinkText( wgAjaxWatch.watching
5866 ? wgAjaxWatch.unwatchingMsg : wgAjaxWatch.watchingMsg);
@@ -120,11 +128,6 @@
121129 }
122130 }
123131
124 - if(!wfSupportsAjax()) {
125 - wgAjaxWatch.supported = false;
126 - return;
127 - }
128 -
129132 // The id can be either for the parent (Monobook-based) or the element
130133 // itself (non-Monobook)
131134 wgAjaxWatch.watchLinks.push( el1.tagName.toLowerCase() == "a"
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1198,7 +1198,7 @@
11991199 * to ensure that client-side caches don't keep obsolete copies of global
12001200 * styles.
12011201 */
1202 -$wgStyleVersion = '79';
 1202+$wgStyleVersion = '80';
12031203
12041204
12051205 # Server-side caching:
Index: trunk/phase3/RELEASE-NOTES
@@ -229,6 +229,8 @@
230230 * Use native XMLHttpRequest class in preference to ActiveX on IE 7; this
231231 avoids the "ActiveX "Do you want to allow ActiveX?" prompt when something
232232 security settings are cranked this way and AJAX-y gets used.
 233+* Delay AJAX watch initialization until click so IE 6 with ugly security
 234+ settings doesn't prompt you until you use the link.
233235
234236
235237 == API changes since 1.10 ==

Follow-up revisions

RevisionCommit summaryAuthorDate
r23581Merged revisions 23406-23580 via svnmerge from...david04:50, 30 June 2007

Status & tagging log